Added option to decide whether hash keys should be sorted#53
Open
haozhexu wants to merge 1 commit into
Open
Conversation
Owner
|
Pardon the tardiness of my response. If the output isn't sorted by key, would the hash end up being re-sorted arbitrarily because ruby hashes aren't sorted? |
Owner
|
Basically I'm not sure if this PR alone will do what you expect. Note this library was originally developed to parse my iphoto library. It was being used on large plist files, with ruby 1.6. I think I added the sort, way back when, because the output was always unpredictably different than expected. The sort in the output was arbitrary, but at least it made sense on some level. If ruby hashes are now ordered, it could make sense to revisit this behavior. I'd prefer to ditch the sort entirely, though of course that may be a breaking change now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash keys are sorted which creates problems in use cases like simply editing and saving of existing plist, whose keys (in dictionaries) are not sorted but after saving the plist the whole file seems to me changed. This PR adds the option to not sort hash keys, by default it's
truein order to be backward compatible with existing behaviour.