Add current_user_privilege_set attributes#15
Merged
Conversation
c6b74bb to
7af5629
Compare
Owner
|
All looks good to me thus far - let me know when you feel it's ready to merge. |
Contributor
Author
|
Hi @pat Actually, I wrote spec only for radicale, but I didn’t try with Apple and Google provider. |
Contributor
Author
|
I moved spec in shared spec and just added a cassette for Apple Calendar. What do you think about it @pat ? |
2f4357b to
22276d9
Compare
Contributor
Author
|
Hi @pat Sorry for the reminder, I know that your time is precious. Have you got a bit of time to review this PR? Thanks a lot, |
Owner
|
Sorry it took me so long to get to this - just released in v0.6.0. Thanks for contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
current-user-privilege-setsupportAdd support for the
current-user-privilege-setWebDAV property (RFC 3744), which exposes the authenticated user's privileges on a calendar (read, write, write-properties, etc.).Cf : https://datatracker.ietf.org/doc/html/rfc3744#section-3.7
Changes
Requests::ListCalendars— Addcurrent-user-privilege-settoPROPERTIESso it is included in PROPFIND requests.Parsers::CalendarXML— Addprivilegesparser that extracts privilege names from the XML response.Calendar— Add:current_user_privilege_settoATTRIBUTES, auto-generating the getter.Clients::CalendarsClient— Add:current_user_privilege_settoDEFAULT_ATTRIBUTESso it is fetched by default.Usage