feat: add chain_spec_key_types support for custom session keys #478
Conversation
DenzelPenzel
force-pushed
the
chain-spec-custom-session-keys
branch
from
c03ba4c to
8eb7b3f
Compare
| .keys() | ||
| .cloned() | ||
| .map(|(image, command)| async { | ||
| let image = image.clone(); |
There was a problem hiding this comment.
Removed cloned because clippy reports an error:`
(/home/runner/work/zombienet-sdk/zombienet-sdk/crates/file-server) error: unneeded cloning of iterator items --> crates/orchestrator/src/network_spec.rs:250:13 | 250 | / image_command_to_nodes_mapping 251 | | .keys() 252 | | .cloned() 253 | | .map(|(image, command)| async { ... | 264 | | Ok::<_, OrchestratorError>((image, command, available_args)) 265 | | }) | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#redundant_iter_cloned = note: -D clippy::redundant-iter-cloned implied by -D warnings = help: to override -D warnings add #[allow(clippy::redundant_iter_cloned)]
| /// - Short: `aura` - uses predefined default scheme (defaults to `sr` if not predefined) | ||
| /// - Long: `aura_sr` - uses explicit scheme | ||
| /// | ||
| /// Returns `None` if the spec is invalid (e.g., invalid scheme). |
There was a problem hiding this comment.
This is not what the code does, only returns None if the spec is empty.
|
|
||
| pub fn get_default_chain_spec_key_types(is_asset_hub_polkadot: bool) -> Vec<ChainSpecKeyType> { | ||
| let predefined_schemes = get_predefined_schemes(is_asset_hub_polkadot); | ||
| let default_keys = [ |
There was a problem hiding this comment.
Maybe we can refactor this to convert the resulting HashMap into the Vec directly.
pepoviola
left a comment
pepoviola
left a comment
There was a problem hiding this comment.
Looks good, some small comments inline.
Thx!
close #473
chain_spec_key_typesfield inNodeConfigandNodeSpecto specify session key types for chain spec injectionchain_spec_key_typesmodule for parsing key type specifications