Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static
aws_authcredentials take an access key and a secret only, so temporary (STS) credentials cannot be used with them: the session token has nowhere to go, and AWS rejects a request signed with a temporary key and no token.This adds an optional
session_tokensource besideaccess_key_idandsecret_access_key. When it is set, the token is carried into the credentials and the request is signed withX-Amz-Security-Token(so it is also inSignedHeaders), as already happens forcredentials_provider: workload_identity. It is refused unless both static fields are set, and nothing changes for a config without it.Tests:
X-Amz-Security-Tokenand signs it;session_tokenwithout the static fields is refused.iron-proxy.example.yamldocuments the new field.