Repository navigation
Conversation
swapBody reads the request body to EOF. On a miss it left the BufferedBody at EOF, so every later match_body secret in the same transform read an empty body and forwarded its placeholder unchanged. Put the bytes back on a miss, as the hit path does. Fixes paradigmxyz#280
4 of 5 tasks
BradleyGoulding
added a commit
to Cryptex-Data-Solutions/iron-proxy
that referenced
this pull request
Oct 23, 2026
…body-after-miss fix(secrets): swap a match_body secret after another one misses (upstream paradigmxyz#281, adapted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280
On a miss,
swapBodyputs the bytes it read back as the body, as the hit path does, so a latermatch_bodysecret in the same transform still sees the body. Includes a regression test that fails without the fix.