🧹 chore: Use daggerverse linear checker - #3
Conversation
Signed-off-by: John McBride <john@papercompute.com>
|
| Filename | Overview |
|---|---|
| .github/workflows/pr.yaml | New PR workflow adding two Dagger-based checks (PR title conformance and Linear magic word). Both dagger call -m invocations omit a version pin on the ghcontrib module, resolving from the default branch at runtime — this makes both checks non-deterministic. |
Sequence Diagram
sequenceDiagram
participant GH as GitHub Actions
participant DaggerGH as dagger/dagger-for-github
participant Dagger as Dagger Engine
participant DV as papercomputeco/daggerverse/ghcontrib (unpinned)
participant GHAPI as GitHub API
GH->>DaggerGH: Install Dagger v0.20.6
GH->>Dagger: dagger call check-pull-request
Dagger->>DV: Resolve module (default branch)
DV->>GHAPI: Fetch PR title via GH_TOKEN
GHAPI-->>DV: PR title
DV-->>GH: Pass / Fail
GH->>DaggerGH: Install Dagger v0.20.6
GH->>Dagger: dagger call check-pull-request-linear-magic-word
Dagger->>DV: Resolve module (default branch)
DV->>GHAPI: Fetch PR description via GH_TOKEN
GHAPI-->>DV: PR body
DV-->>GH: Pass / Fail
Comments Outside Diff (2)
-
.github/workflows/pr.yaml, line 34-38 (link)The daggerverse module reference omits a version tag, so Dagger will resolve
ghcontribfrom the default branch ofpapercomputeco/daggerverseat runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR.Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 34-38 Comment: The daggerverse module reference omits a version tag, so Dagger will resolve `ghcontrib` from the **default branch** of `papercomputeco/daggerverse` at runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR. How can I resolve this? If you propose a fix, please make it concise.
-
.github/workflows/pr.yaml, line 58-62 (link)The same unpinned module reference issue applies here. Both
check-pull-requestandcheck-pull-request-linear-magic-wordcalls should pin to the same explicit version so both jobs behave consistently.Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 58-62 Comment: The same unpinned module reference issue applies here. Both `check-pull-request` and `check-pull-request-linear-magic-word` calls should pin to the same explicit version so both jobs behave consistently. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/workflows/pr.yaml:34-38
The daggerverse module reference omits a version tag, so Dagger will resolve `ghcontrib` from the **default branch** of `papercomputeco/daggerverse` at runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR.
```suggestion
dagger call -m github.com/papercomputeco/daggerverse/ghcontrib@<tag-or-commit> \
--token=env://GH_TOKEN \
--repo="${{ github.repository }}" \
check-pull-request \
--number "${{ github.event.pull_request.number }}"
```
### Issue 2 of 2
.github/workflows/pr.yaml:58-62
The same unpinned module reference issue applies here. Both `check-pull-request` and `check-pull-request-linear-magic-word` calls should pin to the same explicit version so both jobs behave consistently.
```suggestion
dagger call -m github.com/papercomputeco/daggerverse/ghcontrib@<tag-or-commit> \
--token=env://GH_TOKEN \
--repo="${{ github.repository }}" \
check-pull-request-linear-magic-word \
--number "${{ github.event.pull_request.number }}"
```
Reviews (1): Last reviewed commit: "🧹 chore: Use daggerverse linear checker" | Re-trigger Greptile
Adds:
Towards CTO-33