Skip to content

🧹 chore: Use daggerverse linear checker - #3

Merged
jpmcb merged 1 commit into
mainfrom
dagger-linear-check
May 6, 2026
Merged

🧹 chore: Use daggerverse linear checker#3
jpmcb merged 1 commit into
mainfrom
dagger-linear-check

Conversation

@jpmcb

@jpmcb jpmcb commented May 6, 2026

Copy link
Copy Markdown
Contributor

Adds:

  • PR title checker
  • Linear magic word checker

Towards CTO-33

Signed-off-by: John McBride <john@papercompute.com>
@linear-code

linear-code Bot commented May 6, 2026

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented May 6, 2026

Copy link
Copy Markdown

Greptile Summary

This PR introduces a new GitHub Actions workflow (.github/workflows/pr.yaml) that runs two Dagger-based checks on every PR: one for PR title conformance and one for the Linear magic word, both calling the papercomputeco/daggerverse/ghcontrib module.

  • Both dagger call -m invocations reference github.com/papercomputeco/daggerverse/ghcontrib without a version tag, meaning Dagger will resolve the module from the default branch at runtime — any upstream change to that repo will silently affect these checks.
  • The two jobs are structurally identical (checkout → install Dagger → run check), differing only in the final dagger call subcommand; consider whether they could be consolidated in the future to reduce duplication.

Confidence Score: 3/5

Merging will add two always-floating PR checks that pull from an unpinned upstream module — any commit to the daggerverse repo can break or change check behavior without touching this file.

Both Dagger module invocations omit a @version specifier, so they will always resolve from the default branch of papercomputeco/daggerverse. This means the PR title and Linear magic-word checks are non-deterministic: a rename, breaking change, or accidental push to that module repo will silently alter these gates for every future PR in this repo.

.github/workflows/pr.yaml — both dagger call steps need a pinned module version before this workflow can be considered stable.

Important Files Changed

Filename Overview
.github/workflows/pr.yaml New PR workflow adding two Dagger-based checks (PR title conformance and Linear magic word). Both dagger call -m invocations omit a version pin on the ghcontrib module, resolving from the default branch at runtime — this makes both checks non-deterministic.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant DaggerGH as dagger/dagger-for-github
    participant Dagger as Dagger Engine
    participant DV as papercomputeco/daggerverse/ghcontrib (unpinned)
    participant GHAPI as GitHub API

    GH->>DaggerGH: Install Dagger v0.20.6
    GH->>Dagger: dagger call check-pull-request
    Dagger->>DV: Resolve module (default branch)
    DV->>GHAPI: Fetch PR title via GH_TOKEN
    GHAPI-->>DV: PR title
    DV-->>GH: Pass / Fail

    GH->>DaggerGH: Install Dagger v0.20.6
    GH->>Dagger: dagger call check-pull-request-linear-magic-word
    Dagger->>DV: Resolve module (default branch)
    DV->>GHAPI: Fetch PR description via GH_TOKEN
    GHAPI-->>DV: PR body
    DV-->>GH: Pass / Fail
Loading

Comments Outside Diff (2)

  1. .github/workflows/pr.yaml, line 34-38 (link)

    P1 The daggerverse module reference omits a version tag, so Dagger will resolve ghcontrib from the default branch of papercomputeco/daggerverse at runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: .github/workflows/pr.yaml
    Line: 34-38
    
    Comment:
    The daggerverse module reference omits a version tag, so Dagger will resolve `ghcontrib` from the **default branch** of `papercomputeco/daggerverse` at runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
  2. .github/workflows/pr.yaml, line 58-62 (link)

    P1 The same unpinned module reference issue applies here. Both check-pull-request and check-pull-request-linear-magic-word calls should pin to the same explicit version so both jobs behave consistently.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: .github/workflows/pr.yaml
    Line: 58-62
    
    Comment:
    The same unpinned module reference issue applies here. Both `check-pull-request` and `check-pull-request-linear-magic-word` calls should pin to the same explicit version so both jobs behave consistently.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
.github/workflows/pr.yaml:34-38
The daggerverse module reference omits a version tag, so Dagger will resolve `ghcontrib` from the **default branch** of `papercomputeco/daggerverse` at runtime. Any unrelated commit to that repo (breaking API rename, accidental push, etc.) will silently change the behavior of these PR checks with no change to this file — and there's no way to audit which version ran for a given PR.

```suggestion
          dagger call -m github.com/papercomputeco/daggerverse/ghcontrib@<tag-or-commit> \
              --token=env://GH_TOKEN \
              --repo="${{ github.repository }}" \
            check-pull-request \
              --number "${{ github.event.pull_request.number }}"
```

### Issue 2 of 2
.github/workflows/pr.yaml:58-62
The same unpinned module reference issue applies here. Both `check-pull-request` and `check-pull-request-linear-magic-word` calls should pin to the same explicit version so both jobs behave consistently.

```suggestion
          dagger call -m github.com/papercomputeco/daggerverse/ghcontrib@<tag-or-commit> \
              --token=env://GH_TOKEN \
              --repo="${{ github.repository }}" \
            check-pull-request-linear-magic-word \
              --number "${{ github.event.pull_request.number }}"
```

Reviews (1): Last reviewed commit: "🧹 chore: Use daggerverse linear checker" | Re-trigger Greptile

@jpmcb
jpmcb requested a review from a team May 6, 2026 18:56
@jpmcb
jpmcb merged commit 1b1660e into main May 6, 2026
2 checks passed
@jpmcb
jpmcb deleted the dagger-linear-check branch May 6, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants