deps: drop the macOS 10.15 requirement - #235
Merged
Merged
Conversation
wfmash no longer uses std::filesystem, so the conda osx-64 build no longer needs a macOS 10.15 deployment target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wfmash used
std::filesystem::pathfor its index filename fields, which Apple marks available only from macOS 10.15. The conda osx-64 build failed with'path' is unavailable, and the alternative was pinning the deployment target.pangenome/wfmash-rs 34339a7 replaces it with
std::string, so the pin is unnecessary. Same change merged upstream into the v0.14.1 branch as waveygang/wfmash#404.572 tests pass.