fix(analyze): activate body and file-name detectors - #131
Merged
Conversation
This was referenced Aug 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analyze, making all three body-aware detectors liveRefs #66 (slice A of 3; the last slice will close the issue).
Root cause and decision
analyzeusedextract.NewRegistry(), so records had no AST and three detectors returned early. It now uses the AST-enabled registry, matching the advertised fourteen-detector contract.Before / after evidence
Fixture: the reproduction script from #66, run against source builds from the same worktree.
Chain context
Start state:
master@2ccc7c0. End state: defects 1 and 2 fixed; defects 3–7 deliberately remain for later slices. Rollback: revert this one commit; no data migration is required.Verification
go test ./cmd/rootline ./internal/infer -run 'TestAnalyze(RunsBodyAwareDetectors|ThresholdControlsSectionPatterns)|TestDetectStructural_(NamingInconsistencyInRecordFileStems|ScoresFilesAndDirectoriesSeparately)' -count=1just checkjust testjust coverage-check(total 89.6%; every package above its floor)review-33a8d6b218db0d1e)