Make the filter state instance data#4
Open
edgar-bonet wants to merge 1 commit intooymotion:masterfrom
Open
Conversation
In order for multiple instances of EMGFilters to be able to work independently, they must each store its own state. Make this state private class members instead of global variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter state is presently stored in the global variables
LPF,HPFandAHF. The fact that these are global means that all instances ofEMGFiltersshare the same state, and thus interact with each other.This pull request makes this state per-instance data, thus making it possible to use multiple filter instances.
Fixes #3.
Fixes #7.
Note: the patch looks big, but only because the indentation level changed for the methods of
FILTER_2ndandFILTER_4th. If displayed asgit diff -b, it is a small patch.