Skip to content

Dual-stack ephemeral IPs on instance detail#3101

Open
david-crespo wants to merge 1 commit intomainfrom
dual-stack-ips-instance-detail
Open

Dual-stack ephemeral IPs on instance detail#3101
david-crespo wants to merge 1 commit intomainfrom
dual-stack-ips-instance-detail

Conversation

@david-crespo
Copy link
Collaborator

Closes #3042

2026-02-27-dual-stack-ips-instance-detail.mp4

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Feb 28, 2026 0:01am

Request Review

@david-crespo david-crespo marked this pull request as ready for review March 3, 2026 00:22
@david-crespo david-crespo requested a review from charliepark March 3, 2026 00:22
Copy link
Contributor

@charliepark charliepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

? `Only ${availableVersions[0]} pools are shown because this instance already has a ${availableVersions[0] === 'v4' ? 'v6' : 'v4'} ephemeral IP.`
: availableVersions.length === 2
? 'Dual-stack network interfaces support one ephemeral IP per version.'
: undefined
Copy link
Collaborator Author

@david-crespo david-crespo Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch from Señor gpt-5.3-codex: this message is only correct for dual-stack instances and, more subtly, it assumes there are pools available for both stacks. Need to make it conditional on the stack config and probably the pools.

The new info banner can state a false reason for pool filtering. In app/components/AttachEphemeralIpModal.tsx:79, the availableVersions.length === 1 branch always says the instance already has the opposite-version ephemeral IP.

That is not always true:

  • single-stack instances with no ephemeral IP also produce availableVersions.length === 1
  • dual-stack instances with one open version because of pool availability (not because the other version is attached) can also produce length === 1

This creates incorrect user-facing guidance in the modal.

Open question: should that message only appear when the instance is dual-stack and exactly one ephemeral IP is already attached? If yes, the condition needs attached-version context rather than only availableVersions.length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dual stack ephemeral IP attach on instance networking tab

2 participants