Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fe9dc3bf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| impl NodeHeaderLayout for [(); 4] { | ||
| type Header = HandleNodeHeader; |
There was a problem hiding this comment.
Complete the catalog benchmarks before selecting the new layout
This makes the new layout unconditional for four-byte handles, but the commit supplies only historical measurements covering six of the 19 projects in bench/projects.json and explicitly says they were not rerun against the current base. AGENTS.md requires reporting results across the catalog, including regressions and tradeoffs; the supplied subset does not satisfy that requirement. Before landing this default switch, run and report paired parent-versus-candidate single-threaded instruction counts and default-checker peak RSS across the catalog using matching build settings and workloads.
AGENTS.md reference: AGENTS.md:L59-L60
Useful? React with 👍 / 👎.
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
Store immutable kind and data-tag fields beside four-byte parent handles, avoiding packed-field decoding and parent read/modify/write operations. Eight-byte pointers retain the existing packed representation. Select the layout at compile time from pointer width, including
plain-ptrsand 32-bit targets. Preserve the eight-byte header, 24-byte node and existing alignment; introduce no new unsafe operations.Expand the existing integration case to check metadata, parent updates, trailing-comma markers, rare optional-chain fields, node size and alignment.
Existing benchmark evidence from the original commit, before applying it to current main: Apple M2 Max, Rust 1.99.1, identical release builds with fat LTO, one codegen unit, full symbols, no stripping or PGO,
TSRS_FAST=1, and Hyperfine 2. Helpers use warmups and alternating pairs: three at one worker, five at default workers, followed by a reversed default batch. Counters cover the complete helper or CLI, excluding Oxlint. Benchmarks were not rerun for this PR.16-rule helper medians, baseline → candidate. Instructions use one worker; wall time and peak RSS use the reversed default-worker batch:
VS Code default-worker instruction reductions repeat with both 16 rules (1.90% / 1.87%) and 61 rules (2.03% / 1.91%). MUI's single-worker helper regresses 3.66% in instructions and 2.97% in wall time; single-worker peak RSS rises 0.74% on vscode and 0.61% on MUI. Default-worker t3code wall changes are mixed: −0.27% / +1.67% with 16 rules and +2.49% / −3.66% with 61.
Compiler-only single-worker medians from a balanced three-way comparison, baseline → selected layout:
The selected layout reduces instructions more consistently than the smaller packed-byte alternative in the same compiler cohort. Wall time and memory are mixed; these six public projects are the measured catalog subset.
Scoped Clippy passed with default and plain pointers, and formatting passed. Tests were not run for this PR, as requested.