Do not allocate new strings, add support for HTTP3#332
Closed
JakubOnderka wants to merge 3 commits intoowasp-modsecurity:masterfrom
Closed
Do not allocate new strings, add support for HTTP3#332JakubOnderka wants to merge 3 commits intoowasp-modsecurity:masterfrom
JakubOnderka wants to merge 3 commits intoowasp-modsecurity:masterfrom
Conversation
JakubOnderka
force-pushed
the
http3-methods
branch
from
c2d5274 to
037f3e7
Compare
|
JakubOnderka
changed the title
Author
|
Hello, do you plan to merge this? |
Member
|
Hi @JakubOnderka, first of all, many thanks for your contribution! Meanwhile we added some new test to our CI workflow. It would be fine to pick up those modifications and runt those tests. Also would be fine to make some new tests to check the HTTP3 behavior. Let us know if you have any question or we can help you anything. Also, you can join to our Slack server (look for the #project-modsecurity channel). |
|
@JakubOnderka can you split this in two PRs? One for HTTP3, an dthe other for the allocation? I think it will help merging them separately... |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for HTTP3 protocol, that is available in newer nginx.
And also avoid allocating new string for common HTTP methods to make modsecurity little bit faster and consume less memory.