vif-plug-representor: add VF MAC programming#18
Open
dshcherb wants to merge 5 commits into
Open
Conversation
Add VF MAC programming support over devlink using VF representors and unit test coverage (tested functionally on a BF3 DPU). * VF MAC is programmed through DEVLINK_CMD_PORT_SET * The logical port MAC is used for as the VF MAC * Async updates and retries are handled * Unit test coverage for various paths
dimaqq
reviewed
Feb 20, 2026
fnordahl
approved these changes
Mar 20, 2026
fnordahl
left a comment
fnordahl
left a comment
Member
There was a problem hiding this comment.
Nice, thank you for the contribution.
LGTM!
Member
|
@dshcherb could use a rebase though. |
Member
Author
|
Done, thanks a lot for the review! |
The 7 vf-mac-* subcommands were registered in the ovstest dispatch table but had no autotest wrappers, so they were never exercised in CI.
When a VF representor appears at runtime the rename check fires before MAC programming, leaving the VF with its default MAC if OVN claims the port before the rename completes. Move the MAC programming call before the rename guard. Devlink port index is used rather than the netdev name so it is safe to issue while a rename is pending.
Member
Author
|
@dshcherb I'm not really qualifies to review this code, but thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VF MAC programming support over devlink using VF representors and unit test coverage (tested functionally on a BF3 DPU).