Skip to content

feat(typing): preserve adapter promise types - #85

Merged
mcg-web merged 1 commit into
overblog:masterfrom
simPod:fix/generic-promise-types
Aug 18, 2026
Merged

feat(typing): preserve adapter promise types#85
mcg-web merged 1 commit into
overblog:masterfrom
simPod:fix/generic-promise-types

Conversation

@simPod

@simPod simPod commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • make DataLoaderInterface generic over its adapter promise type
  • propagate the type through DataLoader construction, loading, and adapter access

Known limitation:

  • a CacheMap can be shared across different adapters, so a cache hit can return a foreign promise implementation. The generic contract assumes cache maps are not shared across incompatible adapters.

@mcg-web
mcg-web merged commit 7c80a3a into overblog:master Aug 18, 2026
9 checks passed
@simPod
simPod deleted the fix/generic-promise-types branch August 18, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants