Skip to content

Support Traversable keys in loadMany - #79

Merged
mcg-web merged 1 commit into
overblog:masterfrom
simPod:fix/traversable-load-many
Aug 18, 2026
Merged

Support Traversable keys in loadMany#79
mcg-web merged 1 commit into
overblog:masterfrom
simPod:fix/traversable-load-many

Conversation

@simPod

@simPod simPod commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Materialize Traversable input before mapping loads.
  • Preserve iteration order and repeated iterator keys.

Motivation

loadMany() accepts Traversable, but passed it directly to array_map(), which only accepts arrays.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.27%. Comparing base (3a6d9a0) to head (6363e9b).
⚠️ Report is 7 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   59.14%   60.27%   +1.13%     
==========================================
  Files           7        7              
  Lines         350      360      +10     
==========================================
+ Hits          207      217      +10     
  Misses        143      143              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcg-web

mcg-web commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Can you fix this conflict please @simPod ?

@simPod
simPod force-pushed the fix/traversable-load-many branch from 6363e9b to fc8c40b Compare August 18, 2026 06:40
@simPod

simPod commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Done

@simPod

simPod commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Maybe we can address this
image

@mcg-web

mcg-web commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

I'm on it, thanks again !

@mcg-web
mcg-web merged commit d25fe1b into overblog:master Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants