Repository navigation
feat: Add explanations to the third figure - #53
Closed
alainkaegi wants to merge 3 commits into
Closed
alainkaegi wants to merge 3 commits into
alainkaegi wants to merge 3 commits into
Conversation
Closed
To fix the grammar in one sentence, I just added a word that was missing.
jashelio
requested changes
Aug 29, 2026
jashelio
left a comment
jashelio
left a comment
Contributor
There was a problem hiding this comment.
Very nice introductory summary of the functioning of each stage. However, there is just one sentence I did not understand:
"The syntax tree adds another layer of abstraction to facilitate checking that the input corresponds to a well-formed program and attaching meanings to that program."
It starts well but I don't understand the end. There is an English grammar problem that may be causing it, but what I also see is that you seem to be saying that the parser attaches meaning to the program. I would say instead that attaching meaning is what the semantic section is all about.
Collaborator
Author
|
I made a change based on your feedback. Does it help? |
alainkaegi
added a commit
that referenced
this pull request
Sep 9, 2026
Collaborator
Author
|
Fixed in commit 4d8e9bc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to address the third comment in issue #26. Let me know if it's an improvement.