AO3-6385 Fixing overlaping challenge prompts and sorting buttons #5564
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpts and to create formating that is generally less bug prone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6385
Purpose
This change makes it so that prompts no longer overlap with the sorting buttons when viewing the prompt section of a prompt meme collection on small screens. It also reduces the possibility of a similar bug occurring in the future. It accomplishes this by making all elements with the .dashboard .index class go below everything above them on narrow screens, regardless of how they are floated. Since this change only affects elements that take up the full width on narrow screens, it won't create bugs where sections clear side elements.
Testing Instructions
Follow the instructions on Jira to test. To test this on a larger screen, use “responsive design mode” to emulate a smaller screen size. Anything with a width below 670 will work.
Credit
FlyingFalcon they/them