refactor: replace 'throw new' with value-based exceptions for CThreadErr#36
Open
kirito632 wants to merge 1 commit into
Open
refactor: replace 'throw new' with value-based exceptions for CThreadErr#36kirito632 wants to merge 1 commit into
kirito632 wants to merge 1 commit into
Conversation
Using 'throw new CThreadErr' requires manual memory management in catch blocks. Missing 'delete' on the exception pointer causes memory leaks. Replace with value-based throws and catch by const reference, letting the compiler manage exception object lifetime automatically.
markwkm
approved these changes
Apr 3, 2026
Contributor
markwkm
left a comment
markwkm
left a comment
There was a problem hiding this comment.
I think this looks good to me. It might take me a little more time to merge it in.
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase uses
throw new CThreadErr(...)which allocates theexception object on the heap. This requires catch blocks to manually
deletethe pointer to avoid memory leaks. Several catch blocks weremissing this
delete.Replace with value-based throws and catch by
const CThreadErr&,letting the compiler manage the exception object lifetime automatically.
Changes: