Fix IRF-ATN-006 and IRF-ATN-009: Extract naming patterns and enforce file size limits#88
Merged
4444J99 merged 2 commits intoJun 7, 2026
Conversation
…file size limits - IRF-ATN-006: Return CodingPattern objects from _extract_naming_patterns - IRF-ATN-009: Check min_file_size and max_file_size in train() - Adjust tests to not skip small mock files
AI Quality Gate ReportMode:
Duplication
Security
Logic
Advisory mode does not block merge. Review findings before strict mode is enabled. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7a4672454
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type=PatternType.NAMING, | ||
| name=f"function_{case}", | ||
| description=f"Uses {case} for function names", | ||
| frequency=count, |
There was a problem hiding this comment.
When the default min_examples=3 is used, this stores each naming CodingPattern with only the count from the current file, while get_style_profile() filters profile.patterns by that per-pattern frequency. A codebase with three files that each contain one snake_case function has three examples overall, but no function_snake_case pattern is returned by extract_patterns()/patterns_found, so common naming conventions disappear unless enough examples happen to be in a single file.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves IRF-ATN-006 and IRF-ATN-009.