-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for init containers #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
if you don't mind fixing the |
This is required for extraEnv values such as JAVA_OPTS: "-Xms512m -Xmx1024m -XX:+ExitOnOutOfMemoryError".
…plating for use in clusters withouth access to Internet (via local registry). (openzipkin#37) Service - externalTrafficPolicy fix - Chart did not render with default value ({}).
|
also if you don't mind rebasing. cheers |
|
hey @codefromthecrypt, could you have a brief look and merge if possible? I updated and it seems all checks passed this time. |
|
sorry was on holiday and missed the notification |
|
releasing as 0.4.0 thanks! |
|
no problem, hope you had a great holiday. Thank you for merging! 🚀 |
This PR aims to add support for init containers. This will close the issue #33
Changes:
extraInitContainers: []in which the user can specify init containers to be added to the deployment.volumes: []andvolumeMounts: []{}to string. This was becausehelm templatefailed to render the chart in its curent state: