Skip to content

Conversation

@CiucurDaniel
Copy link
Contributor

@CiucurDaniel CiucurDaniel commented May 6, 2025

This PR aims to add support for init containers. This will close the issue #33

Changes:

  • Added new value extraInitContainers: [] in which the user can specify init containers to be added to the deployment.
  • Added support for additional volumes and volume mounts with 2 new values: volumes: [] and volumeMounts: []
  • Changed default value of externalTrafficPolicy from object {} to string. This was because helm template failed to render the chart in its curent state:
Error: values don't meet the specifications of the schema(s) in the following chart(s):
zipkin:
- service.externalTrafficPolicy: Invalid type. Expected: string, given: object

@codefromthecrypt
Copy link
Member

if you don't mind fixing the sh: syntax error: unexpected "done" even if this PR didn't introduce it, appreciated.

sbs1990 added 2 commits May 8, 2025 08:35
This is required for extraEnv values ​​such as JAVA_OPTS: "-Xms512m -Xmx1024m -XX:+ExitOnOutOfMemoryError".
…plating for use in clusters withouth access to Internet (via local registry). (openzipkin#37)

Service - externalTrafficPolicy fix - Chart did not render with default value ({}).
@codefromthecrypt
Copy link
Member

also if you don't mind rebasing. cheers

@CiucurDaniel
Copy link
Contributor Author

hey @codefromthecrypt, could you have a brief look and merge if possible? I updated and it seems all checks passed this time.

@codefromthecrypt codefromthecrypt merged commit 512c46e into openzipkin:master Aug 13, 2025
1 check passed
@codefromthecrypt
Copy link
Member

sorry was on holiday and missed the notification

@codefromthecrypt
Copy link
Member

releasing as 0.4.0 thanks!

@CiucurDaniel
Copy link
Contributor Author

no problem, hope you had a great holiday. Thank you for merging! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants