fix: recognize plural demonic essence keywords in Mazarius NPC

[zoelner]

Description

The Mazarius NPC (Ferumbras' Ascension quest) only recognized the singular keywords demonic essence and essence. When a player typed the plural form (demonic essences / essences) — which matches the wording the NPC itself uses ("I need 30 {demonic essences}...") — the dialogue did not advance. This change adds the plural variants to the keyword check so the conversation flows regardless of how the player phrases the request.

Behaviour

Actual

Saying demonic essences (plural) to Mazarius does nothing; the player must use the exact singular keyword to progress the quest dialogue.

Expected

Saying either the singular or plural form (demonic essence, demonic essences, essence, essences) advances the dialogue and Mazarius asks "Do you have 30 demonic essences to offer to the demonic messenger?".

Fixes #issuenumber

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

• Logged in and talked to Mazarius using the plural keyword demonic essences and confirmed the dialogue advances to the offer prompt.
• Verified the singular keyword demonic essence still works as before.

Test Configuration:

• Server Version: 15.11 (main)
• Client: 15.x
• Operating System: Linux

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works

Summary by CodeRabbit

• Bug Fixes
  • Improved NPC text recognition for the demonic essence trade — plural and partial variants (e.g., "demonic essences", "essence", "essences") now trigger the demonic-essence exchange flow consistently.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db354fc8-7749-4af9-add8-00446a818fa1

📥 Commits

Reviewing files that changed from the base of the PR and between b057c02 and 59877a8.

📒 Files selected for processing (1)

• data-otservbr-global/npc/mazarius.lua

🚧 Files skipped from review as they are similar to previous changes (1)

• data-otservbr-global/npc/mazarius.lua

---

📝 Walkthrough

Walkthrough

The Mazarius NPC dialogue handler now recognizes plural and partial keyword variants when players reference demonic essences. The expanded keyword matching routes "demonic essence", "demonic essences", "essence", and "essences" to the same dialogue flow for the demonic-essence exchange quest.

Changes

Mazarius Demonic Essence Keyword Matching

Layer / File(s)	Summary
Demonic essence keyword variants data-otservbr-global/npc/mazarius.lua	The condition matching player messages about demonic essences is expanded to recognize plural "demonic essences", partial "essence", and "essences" variants alongside the singular "demonic essence", ensuring consistent routing to the demonic-essence exchange flow regardless of exact wording.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through dialogue trees,
Where Mazarius speaks of essences three—
Now "essence," "essences," all forms align,
Plural and partial, the keywords now shine! 🌙
A single-line tweak, yet thorough and fine! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding recognition for plural demonic essence keywords in the Mazarius NPC dialogue routing.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Mazarius NPC dialogue triggers to better recognize plural forms of “demonic essence(s)” during conversation.

Changes:

• Expanded message matching to include plural variants (“demonic essences”, “essences”).
• Kept existing singular/partial keyword matching (“demonic essence”, “essence”).

[gemini-code-assist]

Code Review

This pull request updates the NPC dialogue handling in mazarius.lua to support plural variations of "demonic essence". The review feedback points out that checking for "demonic essence" and "demonic essences" is redundant because the substrings "essence" and "essences" are already being checked, and suggests simplifying the conditional statement.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud