feat: 15.13 npc module protocol and update NPC Lua scripts#3982
Open
dudantas wants to merge 3 commits into
Open
feat: 15.13 npc module protocol and update NPC Lua scripts#3982dudantas wants to merge 3 commits into
dudantas wants to merge 3 commits into
Conversation
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures the profession and speechBubble properties for a large number of NPCs, and updates npcHandler:resetNpc calls to include the npc argument. The review feedback correctly identifies several NPCs that have been assigned incorrect professions and speech bubbles (such as setting animals, interactive objects, and non-banker merchants to "banker", "sailor", or "trader" instead of "normal" or "trader"). These configurations should be corrected to match the actual roles of the NPCs in the game.
Apply bulk updates to NPC scripts under data-otservbr-global/npc. Numerous .lua files were modified to synchronize NPC behavior and data (bug fixes, behavior tweaks, dialogue/localization improvements, and formatting/consistency changes). This is a broad maintenance commit touching many NPC definitions.
dudantas
force-pushed
the
dudantas/import-npc-1513-module
branch
from
3e66fc6 to
5496d41
Compare
majestyotbr
approved these changes
May 26, 2026
|
Contributor
|
@dudantas How to test this PR? |
Member
Author
This is the new NPC window; it's literally just for testing trading NPCs, etc. |
Contributor
|
@dudantas Can you make the client available? I couldn't find it to test |
Member
Author
Added download link to the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes NPC configuration in several Lua files by adding explicit
professionandspeechBubbleproperties to each NPC's config. These changes help clarify each NPC's role (such as "normal" or "trader") and ensure consistent behavior for speech bubbles in the game.NPC configuration standardization:
professionproperty tonpcConfig.flagsfor all affected NPCs, specifying either"normal"or"trader"to clarify NPC roles. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]speechBubbleproperty to each NPC config, using eitherSPEECHBUBBLE_NORMALorSPEECHBUBBLE_TRADEto match the NPC's profession and ensure consistent in-game dialogue presentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Client:
dudantas/tibia-client#18