-
Notifications
You must be signed in to change notification settings - Fork 1
feat(docs): add Google Analytics with privacy-compliant cookie consent #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add cookie consent banner (opt-in) using react-cookie-consent - Google Analytics only loads after user accepts cookies - Add Privacy Policy, Cookie Policy, and Terms of Service pages - Add Legal section to footer with policy links - Enable IP anonymization for GDPR compliance - Fix Getting Started page title in sidebar Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary of ChangesHello @jp-ayyappan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the OpenTDF documentation site by integrating Google Analytics in a privacy-conscious manner. It ensures compliance with major data protection regulations like GDPR and CCPA by requiring explicit user consent for tracking, anonymizing IP addresses, and providing detailed legal documentation. The changes also improve site navigation by correctly labeling a key documentation page. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds Google Analytics tracking with a privacy-compliant cookie consent banner, along with the necessary legal pages. The implementation is well-structured, particularly the conditional loading of analytics scripts based on user consent. I've provided a couple of suggestions for the new src/theme/Root.tsx component to improve maintainability by centralizing configuration and separating styles from logic. The other changes look good.
Address PR review feedback: - Move Google Analytics tracking ID to docusaurus.config.ts customFields - Use useDocusaurusContext hook to access config in Root.tsx - Move cookie consent inline styles to src/css/custom.css - Use CSS classes with Docusaurus theme variables for consistency - Add hover states for improved UX Addresses comments from PR #174 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Address PR review feedback: - Move Google Analytics tracking ID to docusaurus.config.ts customFields - Use useDocusaurusContext hook to access config in Root.tsx - Move cookie consent inline styles to src/css/custom.css - Use CSS classes with Docusaurus theme variables for consistency - Add hover states for improved UX Addresses comments from PR #174 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
5debc51 to
b230dcd
Compare
Fix issue where Google Analytics only loaded on first cookie acceptance but not on subsequent page visits. Changes: - Extract GA initialization into separate function - Add useEffect to check for existing cookie consent on mount - Initialize GA automatically if user previously accepted cookies - Add guard to prevent duplicate GA script loading This ensures analytics tracking works consistently across all page visits after initial consent, not just the first acceptance. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add route change tracking for Single Page Application navigation. Previously, only the initial page load was tracked, but subsequent client-side navigation within the docs was not captured. Changes: - Import useLocation from @docusaurus/router - Add useEffect that listens to location changes - Send page_path to GA on every route change - Include pathname, search params, and hash in tracking - Maintain IP anonymization on all page views This ensures comprehensive analytics tracking across all pages in the documentation site, not just the landing page. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
eugenioenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Address PR review feedback: - Move Google Analytics tracking ID to docusaurus.config.ts customFields - Use useDocusaurusContext hook to access config in Root.tsx - Move cookie consent inline styles to src/css/custom.css - Use CSS classes with Docusaurus theme variables for consistency - Add hover states for improved UX Addresses comments from PR #174 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary
Adds Google Analytics tracking to the OpenTDF documentation site with full GDPR/CCPA compliance through:
Changes
react-cookie-consent/privacy-policy)/cookie-policy)/terms-of-service)Privacy & Legal Compliance
Testing
Screenshots
The cookie consent banner appears at the bottom of all pages with Accept/Decline options and links to privacy policies.
🤖 Generated with Claude Code