build(deps): add ot-literature as a git dependency#116
Merged
Conversation
The new literature_* pyspark steps import from the literature package, but no such dependency was declared. Add it as a git source so uv can resolve the import. Also map the ot-literature distribution name to the literature module name for deptry. The branch pin is temporary (see PR description); flip to vh-restructure-datasets once ot-literature#7 lands.
Per review preference, pin against ot-literature dev rather than the temporary do/bump-pyspark-3.5.7 branch. uv.lock is intentionally not regenerated here: dev currently has pyspark==3.3.4, which conflicts with pts pyspark==3.5.7, so resolution fails. Once the pyspark bump (ot-literature#7) and the match_mapped restructuring land on dev, re-run uv lock to refresh the lockfile against the dev SHA.
3 tasks
vivienho
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new
literature_*pyspark steps in #113 import from theliteraturepackage (e.g.from literature.dataset.match_mapped import MatchMapped), but no such dependency is declared. Without this, the steps fail at import time withModuleNotFoundError. This PR addsot-literatureas a git dependency, mirroring the pattern used forclinical-mining.Changes
pyproject.toml:ot-literatureto[project].dependencies[tool.uv.sources]block pointing atopentargets/ot-literature,branch = "dev"ot-literatureto the import nameliteraturefordeptryuv.lock: auv lockagainstdevis currently not possible (see below). The lockfile in this PR was generated against a temporary branch that has the same content asdevplus the pyspark fix; it will need to be regenerated againstdevonce the upstream blockers below are resolved.Blockers on ot-literature
devuv lockagainstbranch = "dev"fails today:In addition, even after the pyspark conflict is resolved, runtime imports will still fail because
devdoes not yet containmatch_mapped.py(used byliterature_cooccurrence). Both are tracked upstream:dev. Merging it removes the resolver conflict.match_mappedetc. — currently only on thevh-restructure-datasetsbranch in ot-literature; needs to merge intodevfor runtime imports to succeed.Once both have landed on
dev, runuv lockfrom this branch and force-push to refresh the lockfile.Heads-up: transitive dev deps
ot-literaturedeclarespytestandipykernelin its top-leveldependencies(rather than under a dev/optional group), so they will end up in pts's runtime closure. Pre-existing issue inot-literature; out of scope here.Test plan
devhas both fixes,uv lockresolves cleanly anduv syncsucceeds.uv run pts -hsucceeds.uv run pts --step literature_publication(or similar) imports withoutModuleNotFoundError.