Conversation
- Change response/keystone.py -> response/identity - Add get-domain, get-domains tool
- Add create_domain tool - Tests are updated and passing
- Add create, delete, update domain tool - Test codes are updated and passing
- Add id field in update_domain tool - Tests are updated and passing
- Add id field in update_domain tool - Tests are updated and passing - Resolve conlfict
- Resolve conflict
- Delete unnecessary variable in test code.
halucinor
reviewed
Aug 17, 2025
Collaborator
halucinor
left a comment
halucinor
left a comment
There was a problem hiding this comment.
dostring에 required, optional을 명시할 필요는 없어보입니다. 이미 args 주석을 통해 명시된 내용이라서요
| def create_domain( | ||
| self, | ||
| name: str, | ||
| description: str = "", |
Collaborator
There was a problem hiding this comment.
docstring에서 명시된 optional 이랑 실제 인자정보가 다른것 같습니다
choieastsea
reviewed
Aug 17, 2025
choieastsea
approved these changes
Aug 17, 2025
platanus-kr
approved these changes
Aug 18, 2025
platanus-kr
pushed a commit
that referenced
this pull request
Aug 19, 2025
* feat(identity): Add get-domain, get-domains(#31) - Change response/keystone.py -> response/identity - Add get-domain, get-domains tool * feat(identity): Register tool(#31) * feat(identity): Add create domain tool(#31) - Add create_domain tool - Tests are updated and passing * feat(identity): Add create, delete, update domain(#31) - Add create, delete, update domain tool - Test codes are updated and passing * feat(identity): Add id field in update domain tool(#31) - Add id field in update_domain tool - Tests are updated and passing * feat(identity): Add id field in update domain tool(#31) * fix(identity): Fix linter problem(#31)
halucinor
pushed a commit
that referenced
this pull request
Aug 24, 2025
* feat(identity): Add get-domain, get-domains(#31) - Change response/keystone.py -> response/identity - Add get-domain, get-domains tool * feat(identity): Register tool(#31) * feat(identity): Add create domain tool(#31) - Add create_domain tool - Tests are updated and passing * feat(identity): Add create, delete, update domain(#31) - Add create, delete, update domain tool - Test codes are updated and passing * feat(identity): Add id field in update domain tool(#31) - Add id field in update_domain tool - Tests are updated and passing * feat(identity): Add id field in update domain tool(#31) * fix(identity): Fix linter problem(#31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Key Changes
domain 생성 요청할 경우
domain 업데이트 요청할 경우
Related Issues
Additional context
Domain에서 id는 16진수로 이뤄진 랜덤의 문자열로 구성되어 있습니다.
get_domain은 id 대신에 name으로 필드를 수정하고,delete_domain수행 시 name을 입력 받도록 구현했습니다.update_domain의 경우 name 필드가 변경되는 것을 감안하여 id를 입력받도록 구현했습니다.