NO-JIRA: [RHCOS10] Add UBI9 compatibility test tracking doc#102
NO-JIRA: [RHCOS10] Add UBI9 compatibility test tracking doc#102PillaiManish wants to merge 1 commit into
Conversation
Add documentation to track the RHCOS10 baseline compatibility test. No Dockerfile changes — this PR validates the existing UBI9-based image runs correctly on RHCOS10 cluster nodes before migrating to UBI10. Made-with: Cursor
|
@PillaiManish: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PillaiManish The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughA new Markdown document is added to define a baseline RHCOS10 compatibility CI test for the zero-trust-workload-identity-manager operator using UBI9 container images. The document specifies test scope, acceptance criteria, base images, and references a follow-up PR for UBI10 migration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.work/compliance/rhcos10/PR1-ubi9-compat-test.md (1)
27-35: Consider adding exact CI job names/links for reproducibilityThe scope is clear, but adding the concrete prow job names (or links) for
e2eande2e-fipswill make tracking and later audits much easier.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.work/compliance/rhcos10/PR1-ubi9-compat-test.md around lines 27 - 35, Update the test plan to include the exact CI job names or direct links for the e2e runs so they are reproducible: add the canonical prow job identifiers or URL links for the `e2e` and `e2e-fips` jobs next to their bullets (e.g., "e2e — prow-job-name" or a full prow link), and add a brief note that these links point to the authoritative CI job used to validate RHCOS10 to aid tracking and auditing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.work/compliance/rhcos10/PR1-ubi9-compat-test.md:
- Around line 18-23: There is a conflicting build-root version string in the
document: replace one of the occurrences so the canonical value is consistent
(either change the top occurrence 'rhel-9-golang-1.23-openshift-4.19' or the
table entry 'rhel-9-golang-1.23-openshift-4.18')—update whichever is incorrect
to match the intended baseline value and ensure both the standalone mention and
the table row (the "build root (CI)" entry) use the same exact version string.
---
Nitpick comments:
In @.work/compliance/rhcos10/PR1-ubi9-compat-test.md:
- Around line 27-35: Update the test plan to include the exact CI job names or
direct links for the e2e runs so they are reproducible: add the canonical prow
job identifiers or URL links for the `e2e` and `e2e-fips` jobs next to their
bullets (e.g., "e2e — prow-job-name" or a full prow link), and add a brief note
that these links point to the authoritative CI job used to validate RHCOS10 to
aid tracking and auditing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d75ea4c5-b80d-4f8d-a91e-8715dddb9386
📒 Files selected for processing (1)
.work/compliance/rhcos10/PR1-ubi9-compat-test.md
| root uses `rhel-9-golang-1.23-openshift-4.19`: | ||
|
|
||
| | Image | Registry | Current Base | | ||
| |-------|----------|-------------| | ||
| | `zero-trust-workload-identity-manager` | `registry.access.redhat.com` | `ubi9-minimal:9.4` | | ||
| | build root (CI) | `registry.ci.openshift.org/ocp/builder` | `rhel-9-golang-1.23-openshift-4.18` | |
There was a problem hiding this comment.
Resolve conflicting build-root versions in this section
Line 18 says rhel-9-golang-1.23-openshift-4.19, but Line 23 lists rhel-9-golang-1.23-openshift-4.18. Keep one canonical value to avoid ambiguity in the baseline definition.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.work/compliance/rhcos10/PR1-ubi9-compat-test.md around lines 18 - 23, There
is a conflicting build-root version string in the document: replace one of the
occurrences so the canonical value is consistent (either change the top
occurrence 'rhel-9-golang-1.23-openshift-4.19' or the table entry
'rhel-9-golang-1.23-openshift-4.18')—update whichever is incorrect to match the
intended baseline value and ensure both the standalone mention and the table row
(the "build root (CI)" entry) use the same exact version string.
|
/test e2e-operator-fips e2e-operator-rhcos10-fips e2e-operator-rhcos10 |
|
/retest |
1 similar comment
|
/retest |
|
@PillaiManish: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add documentation to track the RHCOS10 baseline compatibility test. No Dockerfile changes — this PR validates the existing UBI9-based image runs correctly on RHCOS10 cluster nodes before migrating to UBI10.
Made-with: Cursor