OCPBUGS-23969,OCPBUGS-64886: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into main#1230
Open
SchSeba wants to merge 12 commits into
Open
OCPBUGS-23969,OCPBUGS-64886: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into main#1230SchSeba wants to merge 12 commits into
SchSeba wants to merge 12 commits into
Conversation
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
add validation webhooks for netfilter nic selector
When a SriovNetwork has a LASTNETWORKNAMESPACE annotation pointing to a namespace where the old NetworkAttachmentDefinition no longer exists, the reconciler returned a NotFound error and blocked creation of the new NAD. Handle NotFound errors gracefully by logging and continuing, so cleanup of non-existent resources does not prevent forward progress. Also fixes swapped Namespace/Name fields in the error log message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
approved
Fix the rdma test, when the device plugin is restarted, the allocatable resource goes to 0 and then back to the original value that caused the test to fail. To not have a flaky test we don't use the consistency check, but an eventually check. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Fix NAD creation blocked by stale LASTNETWORKNAMESPACE annotation
SchSeba
force-pushed
the
merge-bot-master
branch
5 times, most recently
from
1975115 to
a726344
Compare
fix rdma test
SchSeba
force-pushed
the
merge-bot-master
branch
7 times, most recently
from
22244a7 to
7b8bf41
Compare
SchSeba
force-pushed
the
merge-bot-master
branch
2 times, most recently
from
8e66677 to
8c6017f
Compare
Contributor
Author
|
/retitle OCPBUGS-64886: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into main |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
Contributor
|
@SchSeba: This pull request references Jira Issue OCPBUGS-64886, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
SchSeba
force-pushed
the
merge-bot-master
branch
7 times, most recently
from
38e86d5 to
a8e9194
Compare
Contributor
|
/lgtm |
Add .coderabbit.yaml with free_tier enabled for this open-source project, based on the OpenShift coderabbit config but tailored to the SR-IOV network operator codebase. Key customizations: - Enable free_tier (open-source project) - No custom_checks (OpenShift-specific checks removed) - No C/C++ path_instructions (project has no kernel module source files) - Comprehensive path_instructions covering SR-IOV-specific concerns: - Go code: error handling, nil checks on hardware info structs, klog - CRD API types: kubebuilder markers, backward compatibility, webhook consistency - Controllers: idempotent reconcile, finalizer handling, RBAC annotations - Daemon: sysfs/procfs path safety, drain annotations, privileged ops - Vendor NIC plugins: plugin interface, VF limits, switchdev/Mellanox specifics - Webhooks: consistent validation, mutation idempotency - Manifests: security contexts, SR-IOV-specific CRD validation - E2E tests: Ginkgo patterns, VF cleanup, generous hardware timeouts - Supply chain: go.mod checks with openshift/api version coordination - Security tooling: gitleaks, semgrep, checkov, hadolint, trivy, osvScanner, actionlint, ast-grep all enabled
SchSeba
force-pushed
the
merge-bot-master
branch
from
a8e9194 to
097d5d3
Compare
SchSeba
force-pushed
the
merge-bot-master
branch
3 times, most recently
from
65a5233 to
9926282
Compare
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
SchSeba
force-pushed
the
merge-bot-master
branch
from
9926282 to
4a405d8
Compare
…eate-coderabbit-yaml-for-sriov-network create .coderabbit yaml for sriov-network-operator project
SchSeba
force-pushed
the
merge-bot-master
branch
from
4a405d8 to
17e1c93
Compare
Contributor
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…t/github_actions/actions/checkout-7 build(deps): bump actions/checkout from 5 to 7
SchSeba
force-pushed
the
merge-bot-master
branch
from
17e1c93 to
717a185
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.