Skip to content

CORENET-6688: Bump the downstream OVN package to 26.03#3258

Open
miheer wants to merge 1 commit into
openshift:mainfrom
miheer:CORENET-6688
Open

CORENET-6688: Bump the downstream OVN package to 26.03#3258
miheer wants to merge 1 commit into
openshift:mainfrom
miheer:CORENET-6688

Conversation

@miheer

@miheer miheer commented Jun 18, 2026

Copy link
Copy Markdown

Bump the downstream OVN package to 26.03

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Walkthrough

Dockerfile.base OVN build arguments ovnver and ovnver_okd are updated from 25.09 to 26.03. The OKD OVS override (ovsver_okd=3.5) is unchanged, and inline comments documenting the OVS/OVN version alignment requirement are retained.

Changes

OVN Version Bump

Layer / File(s) Summary
OVN ARG version update
Dockerfile.base
ovnver and ovnver_okd bumped from 25.09 to 26.03; ovsver_okd stays at 3.5 with existing alignment comments preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Hop, hop, a version leap!
From 25.09 we used to keep,
Now 26.03 is the way,
OVN jumps into a brand new day.
The rabbit approves — time to deploy! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 6.90% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping the OVN package to version 26.03, which matches the primary update reflected in Dockerfile.base and aligns with the PR's core objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jcaamano and tssurya June 18, 2026 12:59
@miheer

miheer commented Jun 18, 2026

Copy link
Copy Markdown
Author

@tssurya PTAL

1 similar comment
@miheer

miheer commented Jun 18, 2026

Copy link
Copy Markdown
Author

@tssurya PTAL

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go-controller/pkg/sbdb/model.go`:
- Line 1389: The maxInteger constraint value for table_id in the model.go file
is currently set to 33 but should be 23 to match the OVN v26.03.1 schema
specification. Locate the "maxInteger" field definition for table_id and change
the value from 33 to 23. This will ensure proper encoding/decoding compatibility
with the actual OVN Southbound database schema and maintain compatibility with
ovn-controller.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 55c027aa-f0da-4745-ac61-3cca50e29244

📥 Commits

Reviewing files that changed from the base of the PR and between 1061de7 and bf52d4b.

⛔ Files ignored due to path filters (1)
  • dist/images/Dockerfile.fedora is excluded by !**/dist/**
📒 Files selected for processing (15)
  • Dockerfile.base
  • docs/developer-guide/debugging.md
  • docs/features/requirements.md
  • go-controller/Makefile
  • go-controller/pkg/nbdb/acl.go
  • go-controller/pkg/nbdb/logical_router_policy.go
  • go-controller/pkg/nbdb/logical_switch_port.go
  • go-controller/pkg/nbdb/logical_switch_port_health_check.go
  • go-controller/pkg/nbdb/model.go
  • go-controller/pkg/nbdb/network_function.go
  • go-controller/pkg/nbdb/network_function_group.go
  • go-controller/pkg/nbdb/network_function_health_check.go
  • go-controller/pkg/sbdb/advertised_mac_binding.go
  • go-controller/pkg/sbdb/model.go
  • go-controller/pkg/sbdb/service_monitor.go

Comment thread go-controller/pkg/sbdb/model.go Outdated
"type": "integer",
"minInteger": 0,
"maxInteger": 32
"maxInteger": 33

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

What are the Logical_Flow table_id constraints in OVN v26.03.1 schema?

💡 Result:

In the OVN v26.03.1 schema (and consistent with recent versions), the Logical_Flow table in the OVN_Southbound database does not define explicit "constraints" for the table_id column in the sense of a fixed, limited range or a restrictive schema-level validation [1][2]. Instead, the table_id serves as an integer identifier for the logical pipeline stage [3][4]. While the OVSDB schema type for table_id is an integer, its usage is governed by the OVN architectural logic implemented within ovn-northd [5][3]. Key points regarding the table_id in the Logical_Flow table: 1. Architectural Pipeline: The table_id corresponds to specific stages within the logical ingress and egress pipelines (e.g., Ingress Table 0, Ingress Table 1, etc.) [6]. These stages are defined by the OVN architecture, not by hard-coded constraints in the OVSDB schema [3]. 2. Range: There is no strict schema-level restriction (such as minInteger or maxInteger) defined specifically for the table_id column in the OVN_Southbound schema files [1][2]. The pipeline stages are logically ordered and assigned by ovn-northd [3]. 3. Functional Role: It is used by ovn-controller to determine the processing order of flows [3]. If a packet's processing requires transitioning to the next stage, the logical pipeline uses the next or similar actions to increment or jump to the appropriate table_id [3]. For technical specifications regarding which table_id values correspond to which functional stages in version 26.03.1, you should consult the ovn-logical-flows(7) documentation, which details the ingress and egress pipeline stages [6].

Citations:


🏁 Script executed:

cd go-controller && fd -t f "model.go" | head -20

Repository: openshift/ovn-kubernetes

Length of output: 433


🏁 Script executed:

cd go-controller && fd -t f "model.go" -exec wc -l {} \;

Repository: openshift/ovn-kubernetes

Length of output: 255


🏁 Script executed:

cd go-controller && find . -name "model.go" -type f

Repository: openshift/ovn-kubernetes

Length of output: 340


🏁 Script executed:

wc -l ./pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 119


🏁 Script executed:

sed -n '1380,1400p' ./pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 131


🏁 Script executed:

git ls-files | grep "sbdb/model.go"

Repository: openshift/ovn-kubernetes

Length of output: 100


🏁 Script executed:

pwd && ls -la

Repository: openshift/ovn-kubernetes

Length of output: 2515


🏁 Script executed:

wc -l go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 105


🏁 Script executed:

sed -n '1380,1400p' go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 508


🏁 Script executed:

sed -n '1370,1410p' go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 880


🏁 Script executed:

sed -n '1350,1370p' go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 536


🏁 Script executed:

sed -n '1330,1360p' go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 732


🏁 Script executed:

git log --oneline -p go-controller/pkg/sbdb/model.go | grep -A 5 -B 5 '"maxInteger": 33' | head -30

Repository: openshift/ovn-kubernetes

Length of output: 312


🏁 Script executed:

git log -p go-controller/pkg/sbdb/model.go | grep -B 10 -A 10 'maxInteger.*3[23]' | head -60

Repository: openshift/ovn-kubernetes

Length of output: 50


🏁 Script executed:

git log --oneline -n 20 -- go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 110


🏁 Script executed:

git show bf52d4b21:go-controller/pkg/sbdb/model.go | sed -n '1385,1395p'

Repository: openshift/ovn-kubernetes

Length of output: 300


🏁 Script executed:

git show bf52d4b21~1:go-controller/pkg/sbdb/model.go | sed -n '1385,1395p'

Repository: openshift/ovn-kubernetes

Length of output: 110


🏁 Script executed:

git log --oneline -n 5 -- go-controller/pkg/sbdb/model.go

Repository: openshift/ovn-kubernetes

Length of output: 110


🏁 Script executed:

git show bf52d4b21 -- go-controller/pkg/sbdb/model.go | grep -B 5 -A 5 "maxInteger.*3[23]"

Repository: openshift/ovn-kubernetes

Length of output: 1271


🏁 Script executed:

git log --all --oneline -- go-controller/pkg/sbdb/model.go | head -20

Repository: openshift/ovn-kubernetes

Length of output: 1045


🏁 Script executed:

git show bf52d4b21 -- go-controller/pkg/sbdb/model.go | head -100

Repository: openshift/ovn-kubernetes

Length of output: 3731


🏁 Script executed:

git show 9b2be2983:go-controller/pkg/sbdb/model.go | grep -A 8 '"table_id"'

Repository: openshift/ovn-kubernetes

Length of output: 263


🏁 Script executed:

git diff 9b2be2983..bf52d4b21 -- go-controller/pkg/sbdb/model.go | grep -B 5 -A 5 '"table_id"'

Repository: openshift/ovn-kubernetes

Length of output: 50


🏁 Script executed:

web_search
What is the Logical_Flow table_id maxInteger constraint in the OVN 26.03.1 schema file?

Repository: openshift/ovn-kubernetes

Length of output: 162


🏁 Script executed:

web_search
OVN 26.03.1 Logical_Flow table_id schema constraint specification

Repository: openshift/ovn-kubernetes

Length of output: 161


🌐 Web query:

OVN 26.03.1 Logical_Flow table_id maxInteger constraint schema

💡 Result:

In OVN version 26.03, the table_id column in the Logical_Flow table of the OVN_Southbound database is defined with a constraint that limits its integer value [1]. Specifically, the OVSDB schema for ovn-sb specifies that table_id must be an integer within the range of 0 to 23 [1]. This constraint ensures that logical flows are categorized into defined stages within the logical pipeline, analogous to OpenFlow table numbers [2][3]. While older versions of OVN may have utilized different ranges (such as 0 to 32 or 33 in previous releases) [2][4][3], the schema for version 26.03.0 explicitly sets the maxInteger constraint for table_id to 23 [1].

Citations:


Fix maxInteger constraint for table_id to match OVN v26.03.1 schema.

The maxInteger value for table_id should be 23, not 33, according to the OVN v26.03.1 schema specification. The current value of 33 will cause encoding/decoding mismatches with the actual OVN Southbound database schema and may break compatibility with ovn-controller.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go-controller/pkg/sbdb/model.go` at line 1389, The maxInteger constraint
value for table_id in the model.go file is currently set to 33 but should be 23
to match the OVN v26.03.1 schema specification. Locate the "maxInteger" field
definition for table_id and change the value from 33 to 23. This will ensure
proper encoding/decoding compatibility with the actual OVN Southbound database
schema and maintain compatibility with ovn-controller.

Comment thread dist/images/Dockerfile.fedora Outdated
########################################
FROM quay.io/fedora/fedora:43 AS kojidownloader
ARG ovnver=ovn-25.09.2-82.fc43
ARG ovnver=ovn-26.03.1-50.fc43

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this an upstream file? did we miss it there?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this an upstream file? did we miss it there?

The bot has not yet merged PR https://github.com/ovn-kubernetes/ovn-kubernetes/pull/6532 for ovn bump in upstream ovnk

Bump the downstream OVN package to 26.03.

The rest of the OVN 26.03 schema, Fedora image, and documentation changes will arrive through the normal downstream sync.

Signed-off-by: Miheer Salunke <miheer.salunke@gmail.com>
@tssurya

tssurya commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

please update the PR description to be a single line that tells we are bumping OVN :D

@miheer

miheer commented Jun 18, 2026

Copy link
Copy Markdown
Author

please update the PR description to be a single line that tells we are bumping OVN :D

done

@miheer miheer changed the title Bump OVN RPM to 26.03.1-50.fc43 CORENET-6688: Bump OVN RPM to 26.03.1-50.fc43 Jun 18, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@miheer: This pull request references CORENET-6688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Bump the downstream OVN package to 26.03

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miheer

miheer commented Jun 18, 2026

Copy link
Copy Markdown
Author

/retest

@miheer miheer changed the title CORENET-6688: Bump OVN RPM to 26.03.1-50.fc43 CORENET-6688: Bump the downstream OVN package to 26.03 Jun 18, 2026
@miheer

miheer commented Jun 19, 2026

Copy link
Copy Markdown
Author

/retest

7 similar comments
@miheer

miheer commented Jun 19, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 19, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 20, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 20, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 20, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 20, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 20, 2026

Copy link
Copy Markdown
Author

/retest

@tssurya tssurya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@miheer please make sure CI is fully green - then add "verified by CI" yourself

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miheer, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@miheer

miheer commented Jun 23, 2026

Copy link
Copy Markdown
Author

/retest

@miheer

miheer commented Jun 23, 2026

Copy link
Copy Markdown
Author

@tssurya these tests are failing due to flakes. I will re-run them
For example:

Running Command: curl -L --retry 5 https://github.com/operator-framework/operator-registry/releases/download/v1.26.2/linux-amd64-opm -o /tmp/bin/opm && chmod +x /tmp/bin/opm
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) Received HTTP code 403 from proxy after CONNECT

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@miheer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw 91d29f7 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-azure-ovn-upgrade 91d29f7 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-local-gateway 91d29f7 link true /test e2e-aws-ovn-upgrade-local-gateway

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miheer

miheer commented Jun 23, 2026

Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants