Skip to content

NO-ISSUE: OTE: Promote 37 stable NetworkSegmentation tests to blocking#3255

Open
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:promote-netseg-blocking-stable
Open

NO-ISSUE: OTE: Promote 37 stable NetworkSegmentation tests to blocking#3255
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:promote-netseg-blocking-stable

Conversation

@mkowalski

@mkowalski mkowalski commented Jun 17, 2026

Copy link
Copy Markdown

Summary

Promote 37 NetworkSegmentation e2e tests from InformingTests to BlockingTests in the OTE test lifecycle configuration.

These tests have been running at 98-99.9% pass rate on the 5.0 informing test suite and are ready to graduate to blocking.

Tests promoted

Category Tests Pass rate
L2 primary UDN east/west traffic (CUDN, NAD, UDN) 6 99.7-99.8%
L2 primary UDN networkStatus annotations 6 99.7-99.8%
L2 secondary UDN CRD controller 3 98.2%
CUDN CRD controller (NAD lifecycle, namespace-selector) 6 99.7-99.8%
Default network multus annotation (VAP, static IP/MAC) 3 99.6%
Network Policies on primary UDN (L2/L3 dualstack) 3 99.5-99.7%
Preconfigured Layer2 UDN (config, validation, unmasked reserved/infra subnets) 9 99.6-100%
Network name conflict prevention 1 99.8%

Note on the unmasked IPv4 reserved subnets test

This test is now included (it was previously held back as "insufficient data"). Over a 30-day window it runs at 99.85% (n=16446), essentially identical to its already-promoted sibling unmasked IPv4 infrastructure subnets (99.84%, n=16450). The four unmasked reserved/infrastructure tests (IPv4/IPv6 × reserved/infrastructure) are now promoted together as a coherent group.

Not promoted (kept informing)

  • 11 L3 primary UDN tests: temporarily regressed due to OCPBUGS-89327 subnet validation bug (96.5% monthly rate, dipped to ~81% in the last week). Will be promoted in a follow-up PR once the fix (ovn-kubernetes#6533) lands.
  • 1 NodePort service test: 0% pass rate, needs a separate fix.
  • 44 EVPN/BGP tests: separate feature area, not addressed here.

Data source

Pass rates from Sippy, aggregated over a 30-day window across active releases (4.22 / 4.23 / 5.0) via the Component Readiness test_details API.


🤖 This PR was generated by AI on behalf of @mkowalski, who has reviewed it.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Walkthrough

InformingTests in openshift/test/tests.go is updated to a revised subset of NetworkSegmentation test names. BlockingTests, previously empty, is populated with a list of NetworkSegmentation test identifiers, promoting those tests to CI-blocking status.

Changes

NetworkSegmentation CI Test Classification

Layer / File(s) Summary
InformingTests and BlockingTests reclassification
openshift/test/tests.go
InformingTests NetworkSegmentation entries are replaced with a different subset of test names; BlockingTests changes from an empty []string{} to a populated slice of NetworkSegmentation test identifiers that now block CI.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the tests have moved today,
From "informing" lanes to "blocking" they say,
NetworkSegmentation stands firm and tall,
Now guarding the gate so CI won't fall.
A new subset informs, the rest block the way! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: promoting 36 NetworkSegmentation tests from InformingTests to BlockingTests, which directly matches the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski mkowalski changed the title Promote 36 stable NetworkSegmentation tests to blocking OTE: Promote 36 stable NetworkSegmentation tests to blocking Jun 17, 2026
@mkowalski mkowalski changed the title OTE: Promote 36 stable NetworkSegmentation tests to blocking NO-ISSUE: OTE: Promote 36 stable NetworkSegmentation tests to blocking Jun 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mkowalski: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Promote 36 NetworkSegmentation e2e tests from InformingTests to BlockingTests in the OTE test lifecycle configuration.

These tests have been running at 98-99.8% pass rate on the 5.0 informing test suite and are ready to graduate to blocking.

Tests promoted

Category Tests Pass rate
L2 primary UDN east/west traffic (CUDN, NAD, UDN) 6 99.7-99.8%
L2 primary UDN networkStatus annotations 6 99.7-99.8%
L2 secondary UDN CRD controller 3 98.2%
CUDN CRD controller (NAD lifecycle, namespace-selector) 6 99.7-99.8%
Default network multus annotation (VAP, static IP/MAC) 3 99.6%
Network Policies on primary UDN (L2/L3 dualstack) 3 99.5-99.7%
Preconfigured Layer2 UDN (config, validation, reserved subnets) 8 99.6-99.8%
Network name conflict prevention 1 99.8%

Not promoted (kept informing)

  • 11 L3 primary UDN tests: temporarily regressed due to OCPBUGS-89327 subnet validation bug (96.5% monthly rate, dipped to ~81% in the last week). Will be promoted in a follow-up PR once the fix (ovn-kubernetes#6533) lands.
  • 1 NodePort service test: 0% pass rate, needs a separate fix.
  • 1 unmasked reserved subnets test: insufficient data.
  • 44 EVPN/BGP tests: separate feature area, not addressed here.

Data source

Pass rates from Sippy 5.0 current period.


🤖 This PR was generated by AI on behalf of @mkowalski, who has reviewed it.

Summary by CodeRabbit

  • Tests
  • Enhanced CI validation by updating NetworkSegmentation test configurations with additional test identifiers in the blocking test suite for improved coverage.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

These NetworkSegmentation tests have been running at 98-99.8% pass rate
on the 5.0 informing test suite and are ready to graduate to blocking.

Tests promoted cover:
- L2 primary UDN east/west traffic (CUDN, NAD, UDN variants)
- L2 primary UDN networkStatus annotations
- L2 secondary UDN CRD controller operations
- ClusterUserDefinedNetwork CRD controller (NAD lifecycle, namespace-selector)
- Default network multus annotation (VAP protection, static IP/MAC)
- Network Policies on primary UDN (L2/L3 dualstack)
- Preconfigured Layer2 UDN (basic config, custom subnets, validation,
  unmasked reserved/infrastructure subnets IPv4/IPv6)
- Network name conflict prevention

The "unmasked IPv4 reserved subnets" test is included: over a 30-day
window it runs at 99.85% (n=16446), matching its already-promoted
sibling "unmasked IPv4 infrastructure subnets" (99.84%, n=16450). The
four unmasked reserved/infrastructure tests are promoted together as a
group.

Not promoted (kept informing):
- 11 L3 primary UDN tests: affected by OCPBUGS-89327 subnet validation
  regression (96.5% monthly, temporary dip to 81%). Will be promoted
  separately once the fix lands.
- 1 NodePort service test: 0% pass rate, needs separate fix.
- 44 EVPN/BGP tests: separate feature area, not addressed here.

Signed-off-by: Mateusz Kowalski <mko@redhat.com>
Generated-by: AI
@mkowalski mkowalski force-pushed the promote-netseg-blocking-stable branch from b8b411c to 14f0ed4 Compare June 18, 2026 10:21
@mkowalski mkowalski changed the title NO-ISSUE: OTE: Promote 36 stable NetworkSegmentation tests to blocking NO-ISSUE: OTE: Promote 37 stable NetworkSegmentation tests to blocking Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 14f0ed4 link true /test unit
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 14f0ed4 link true /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/qe-perfscale-payload-control-plane-6nodes 14f0ed4 link true /test qe-perfscale-payload-control-plane-6nodes
ci/prow/e2e-aws-ovn-upgrade 14f0ed4 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw 14f0ed4 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-aws-ovn-serial 14f0ed4 link true /test e2e-aws-ovn-serial
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp 14f0ed4 link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade 14f0ed4 link true /test 5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-rhcos10-techpreview 14f0ed4 link false /test e2e-aws-ovn-rhcos10-techpreview
ci/prow/e2e-aws-ovn-local-gateway 14f0ed4 link true /test e2e-aws-ovn-local-gateway
ci/prow/e2e-azure-ovn-upgrade 14f0ed4 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-local-gateway 14f0ed4 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-aws-ovn 14f0ed4 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-ovn-techpreview 14f0ed4 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack 14f0ed4 link true /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants