Skip to content

Update openshift-tests-extension to latest#3250

Open
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:revendor-ote-extension
Open

Update openshift-tests-extension to latest#3250
anuragthehatter wants to merge 1 commit into
openshift:mainfrom
anuragthehatter:revendor-ote-extension

Conversation

@anuragthehatter

@anuragthehatter anuragthehatter commented Jun 15, 2026

Copy link
Copy Markdown

Summary

Root cause

RunSpec in openshift/onsi-ginkgo's suite_patch.go previously used NoopOutputInterceptor, so any direct os.Stdout writes from test code (kube e2e framework STEP logs, exutil.CLI output) leaked to process stdout alongside the JSON result. The harness then failed to parse the mixed output as JSON, reporting passing tests as failures with Deserialization Error: invalid character 'S' looking for beginning of value.

Test plan

  • go build passes
  • CI: OTP tests that previously showed false deserialization failures should now pass

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to ensure stability and compatibility with latest upstream components.

Update from v0.0.0-20260127 to v0.0.0-20260612. This pulls in the
ForwardingOutputInterceptor fix from openshift/onsi-ginkgo#23 which
ensures stdout/stderr from test code is captured into CapturedStdOutErr
instead of leaking to the process stdout. This fixes false test failures
caused by test output contaminating JSON results in parallel execution.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: bf44c8dd-e2c6-4ed1-bd85-f8e8b54aa2d8

📥 Commits

Reviewing files that changed from the base of the PR and between 62baca4 and a30fdc1.

⛔ Files ignored due to path filters (1)
  • openshift/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • openshift/go.mod

Walkthrough

The github.com/openshift-eng/openshift-tests-extension module version in openshift/go.mod is bumped from v0.0.0-20260127124016-0fed2b824818 to v0.0.0-20260612102633-2fd5b2fa4221.

Changes

Dependency Version Bump

Layer / File(s) Summary
Update openshift-tests-extension version
openshift/go.mod
Replaces the pseudo-version of github.com/openshift-eng/openshift-tests-extension with a newer commit-dated pseudo-version (20260612102633-2fd5b2fa4221).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single line hops left, a new one lands right,
The module version leaps to a fresher height.
No fanfare needed, just one tiny swap,
A dependency fresh from the burrow's map.
🐇✨ Onward we hop!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: updating the openshift-tests-extension dependency to a newer version, which directly matches the single file change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jcaamano and kyrtapz June 15, 2026 21:11
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign martinkennelly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@anuragthehatter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade-local-gateway a30fdc1 link true /test e2e-aws-ovn-upgrade-local-gateway
ci/prow/e2e-aws-ovn-upgrade a30fdc1 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-edge-zones a30fdc1 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp a30fdc1 link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/security a30fdc1 link false /test security
ci/prow/e2e-aws-ovn-local-gateway a30fdc1 link true /test e2e-aws-ovn-local-gateway
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw a30fdc1 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-metal-ipi-ovn-dualstack a30fdc1 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-ovn-rhcos10-techpreview a30fdc1 link false /test e2e-aws-ovn-rhcos10-techpreview
ci/prow/e2e-gcp-ovn-techpreview a30fdc1 link true /test e2e-gcp-ovn-techpreview
ci/prow/5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade a30fdc1 link true /test 5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants