-
Notifications
You must be signed in to change notification settings - Fork 466
NO-ISSUE: Fix cleanup verification timeouts in e2e-ocl tests #5652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Fix cleanup verification timeouts in e2e-ocl tests #5652
Conversation
The cleanupEphemeralBuildObjects function was experiencing intermittent timeout failures during cleanup verification, even though deletions were succeeding. Each verification used 5-minute default timeout with 1s poll interval which could exhaust rate limits leading to the "context deadline exceeded" error. Create a dedicated 2-minute timeout context for cleanup verification and increase poll interval from 1s to 3s to reduce API call rate which should be about 40 attempts per resource. Signed-off-by: Urvashi <[email protected]>
|
@umohnani8: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified bypass verified by passing ocl test |
|
/verified bypass |
|
@umohnani8: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umohnani8: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The cleanupEphemeralBuildObjects function was experiencing intermittent timeout failures during cleanup verification, even though deletions were succeeding.
Each verification used 5-minute default timeout with 1s poll interval which could exhaust rate limits leading to the "context deadline exceeded" error.
Create a dedicated 2-minute timeout context for cleanup verification and increase poll interval from 1s to 3s to reduce API call rate which should be about 40 attempts per resource.