CORS-4503: bump cluster-api to v1.12.8#10587
Conversation
Bump sigs.k8s.io/cluster-api from v1.11.8 to v1.12.8 to pick up the graduated v1beta2 API, which includes MachineTaint support for setting node taints via MachineSet/MachineDeployment.
go mod vendor
|
@tthvo: This pull request references CORS-4503 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis pull request updates the OpenShift installer's cluster-api dependency from v1.11.3 to v1.12.8, along with reconciling all transitive dependencies to compatible versions required by the new cluster-api release. The go.mod file is modified to reflect the primary bump and cascading indirect dependency changes across gRPC gateway, observability instrumentation, Kubernetes APIs, and related packages. ChangesCluster API and Dependency Upgrades
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/cc @patrickdillon |
|
/hold I haven't noticed any breaking changes in CAPI |
|
/test e2e-azure-ovn |
|
/test e2e-ibmcloud-ovn |
|
/hold cancel So far, CI results look good :D There is no "breaking" in CAPI v1.12. |
|
/test e2e-vsphere-ovn-techpreview e2e-vsphere-static-ovn |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR bumps
sigs.k8s.io/cluster-apiversion tov1.12.8for both top-level (manifest generation)go.modand CAPI controllergo.mod.Motivations
There are some benefits to use
v1.12such as:v1beta2API (removal in April 2027).MachineTaintsupport onMachineSpecto enable setting node taints viaMachineSet/MachineDeployment. This is required for edge compute pool managed via day-2 CAPI/CAPA.Important
As of CAPI
v1.12,v1beta1API is still available (tentative removal in April 2027); thus, it should still be backwards compatible with installer-generated manifests. See migration guide.Summary by CodeRabbit