-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-43501: fix kargs handling in ABI Minimal ISO #10578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ require ( | |
| github.com/coreos/stream-metadata-go v0.4.10-0.20250806142651-4a7d280a6c7b | ||
| github.com/daixiang0/gci v0.13.5 | ||
| github.com/digitalocean/go-libvirt v0.0.0-20240220204746-fcabe97a6eed | ||
| github.com/diskfs/go-diskfs v1.4.1 | ||
| github.com/diskfs/go-diskfs v1.7.1-0.20251217162235-58541aa8f559 | ||
| github.com/form3tech-oss/jwt-go v3.2.3+incompatible | ||
| github.com/go-logr/logr v1.4.3 | ||
| github.com/go-openapi/errors v0.22.1 | ||
|
|
@@ -60,7 +60,7 @@ require ( | |
| github.com/gophercloud/utils/v2 v2.0.0-20250212084022-725b94822eeb | ||
| github.com/h2non/filetype v1.0.12 | ||
| github.com/hashicorp/go-multierror v1.1.1 | ||
| github.com/hashicorp/go-version v1.7.0 | ||
| github.com/hashicorp/go-version v1.8.0 | ||
| github.com/jarcoal/httpmock v1.3.1 | ||
| github.com/jongio/azidext/go/azidext v0.5.0 | ||
| github.com/kdomanski/iso9660 v0.2.1 | ||
|
|
@@ -70,9 +70,9 @@ require ( | |
| github.com/microsoftgraph/msgraph-sdk-go v0.59.0 | ||
| github.com/nutanix-cloud-native/cluster-api-provider-nutanix v1.7.0 | ||
| github.com/nutanix-cloud-native/prism-go-client v0.5.0 | ||
| github.com/onsi/gomega v1.38.2 | ||
| github.com/onsi/gomega v1.39.1 | ||
| github.com/openshift/api v0.0.0-20260429122012-1180c0f5c3e9 | ||
| github.com/openshift/assisted-image-service v0.0.0-20250917153356-4ca9ff81f712 | ||
| github.com/openshift/assisted-image-service v0.0.0-20260428115106-2b81dd8e7120 | ||
| github.com/openshift/assisted-service/api v0.0.0 | ||
| github.com/openshift/assisted-service/client v0.0.0 | ||
| github.com/openshift/assisted-service/models v0.0.0 | ||
|
|
@@ -94,7 +94,7 @@ require ( | |
| github.com/prometheus/common v0.67.4 | ||
| github.com/rogpeppe/go-internal v1.14.1 | ||
| github.com/shurcooL/vfsgen v0.0.0-20181202132449-6a9ea43bcacd | ||
| github.com/sirupsen/logrus v1.9.4-0.20230606125235-dd1b4c2e81af | ||
| github.com/sirupsen/logrus v1.9.4 | ||
| github.com/spf13/cobra v1.10.1 | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/thedevsaddam/retry v0.0.0-20200324223450-9769a859cc6d | ||
|
|
@@ -161,13 +161,16 @@ require ( | |
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.30.0 // indirect | ||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.53.0 // indirect | ||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.53.0 // indirect | ||
| github.com/anchore/go-lzo v0.1.0 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/cloudfront v1.40.4 // indirect | ||
| github.com/aws/aws-sdk-go-v2/service/signin v1.0.6 // indirect | ||
| github.com/cncf/xds/go v0.0.0-20251210132809-ee656c7534f5 // indirect | ||
| github.com/djherbis/times v1.6.0 // indirect | ||
| github.com/envoyproxy/go-control-plane/envoy v1.36.0 // indirect | ||
| github.com/envoyproxy/protoc-gen-validate v1.3.0 // indirect | ||
| github.com/go-jose/go-jose/v4 v4.1.3 // indirect | ||
| github.com/golangci/plugin-module-register v0.1.2 // indirect | ||
| github.com/klauspost/compress v1.18.0 // indirect | ||
|
Comment on lines
+164
to
+173
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "Check vulnerable module in go.mod:"
rg -n 'github.com/go-jose/go-jose/v4' go.mod go.sum
echo
echo "Query OSV for affected range:"
curl -s https://api.osv.dev/v1/query -H 'Content-Type: application/json' -d '{
"package": {"name":"github.com/go-jose/go-jose/v4","ecosystem":"Go"},
"version":"4.1.3"
}' | jq '.vulns[] | {id, summary, aliases, affected: .affected[].ranges}'Repository: openshift/installer Length of output: 2072 Bump vulnerable dependency github.com/go-jose/go-jose/v4 from 4.1.3 to a patched release.
🧰 Tools🪛 OSV Scanner (2.3.8)[HIGH] 171-171: github.com/go-jose/go-jose/v4 4.1.3: Go JOSE Panics in JWE decryption in github.com/go-jose/go-jose (GO-2026-4945) [HIGH] 171-171: github.com/go-jose/go-jose/v4 4.1.3: Go JOSE Panics in JWE decryption 🤖 Prompt for AI Agents |
||
| github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect | ||
| github.com/spiffe/go-spiffe/v2 v2.6.0 // indirect | ||
| github.com/std-uritemplate/std-uritemplate/go/v2 v2.0.5 // indirect | ||
|
|
@@ -226,7 +229,6 @@ require ( | |
| github.com/coreos/go-systemd/v22 v22.6.0 // indirect | ||
| github.com/coreos/vcontext v0.0.0-20230201181013-d72178a18687 // indirect | ||
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
| github.com/djherbis/times v1.6.0 // indirect | ||
| github.com/docker/go-units v0.5.0 // indirect | ||
| github.com/elliotwutingfeng/asciiset v0.0.0-20230602022725-51bbb787efab // indirect | ||
| github.com/emicklei/go-restful/v3 v3.13.0 // indirect | ||
|
|
@@ -269,7 +271,6 @@ require ( | |
| github.com/josharian/intern v1.0.0 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect | ||
| github.com/klauspost/compress v1.18.0 // indirect | ||
| github.com/kr/fs v0.1.0 // indirect | ||
| github.com/kylelemons/godebug v1.1.0 // indirect | ||
| github.com/leodido/go-urn v1.4.0 // indirect | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
`For each module below, find the latest stable (non-prerelease, non-pseudo-version) release and whether the required fix exists in that stable tag:
Also check whether either referenced pseudo-version was later yanked or superseded due to regressions.`
💡 Result:
Citations:
🏁 Script executed:
Repository: openshift/installer
Length of output: 153
🏁 Script executed:
Repository: openshift/installer
Length of output: 7919
🏁 Script executed:
Repository: openshift/installer
Length of output: 143
🏁 Script executed:
Repository: openshift/installer
Length of output: 506
🌐 Web query:
osv.dev github.com/go-jose/go-jose/v4 v4.1.3 affected fixed💡 Result:
The Go module github.com/go-jose/go-jose/v4 at version v4.1.3 is affected by a security vulnerability identified as GHSA-78h2-9frx-2jm8 [1][2]. Vulnerability Details: The issue involves a panic during JSON Web Encryption (JWE) decryption [1][3]. The panic is triggered when the alg field in a JWE object specifies a key wrapping algorithm (specifically those ending in KW, excluding A128GCMKW, A192GCMKW, and A256GCMKW) and the encrypted_key field is empty [1][2]. This behavior occurs because the cipher.KeyUnwrap function attempts to allocate a slice with a zero or negative length based on the length of the empty encrypted_key field [1][2]. Affected Versions: - github.com/go-jose/go-jose/v4: Version v4.1.3 is affected [1][4]. Fixed Versions: - The vulnerability is fixed in version v4.1.4 and later [1][2][5]. Mitigation: If upgrading to v4.1.4 is not immediately possible, you can mitigate this vulnerability if your application does not require key wrapping algorithms. If the list of keyAlgorithms passed to ParseEncrypted, ParseEncryptedJSON, or ParseEncryptedCompact excludes key wrapping algorithms (those ending in KW), the application remains unaffected [1][3]. Additionally, developers using key wrapping can implement pre-validation to ensure the encrypted_key field in the JWE object is not empty [1][2].
Citations:
Replace disallowed pseudo-version pins and upgrade vulnerable
go-josego.modpins prerelease pseudo-versions for production dependencies:github.com/diskfs/go-diskfs v1.7.1-0.20251217162235-58541aa8f559(line 45)github.com/openshift/assisted-image-service v0.0.0-20260428115106-2b81dd8e7120(line 75)Replace with tagged stable releases (or document a written exception + follow-up target).
github.com/go-jose/go-jose/v4 v4.1.3(line 171) is affected by GHSA-78h2-9frx-2jm8; fixed in v4.1.4+ → bump tov4.1.4or later.github.com/anchore/go-lzo v0.1.0 // indirect(line 164): if introduced in this change, provide need/license evidence per policy.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the versions from the library module.
go-diskfs is pinned because it contains an important unreleased bug fix.
go-lzo is MIT licensed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaneb, understood — thanks for the context. The pseudo-version pins make sense given the fixes aren't yet in a stable upstream release, and MIT is unambiguously acceptable forgo-lzo.The one outstanding item from the original review that wasn't covered:
github.com/go-jose/go-jose/v4 v4.1.3is affected by GHSA-78h2-9frx-2jm8 (panic on JWE decryption whenencrypted_keyis empty, fixed inv4.1.4). Is that within scope to bump here, or is it also constrained by a transitive dependency floor fromassisted-image-service?✏️ Learnings added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go-jose has nothing to do with this patch and isn't modified by it.