OTA-2064: Rename Proposal API to AgenticRun#1422
Conversation
The upstream lightspeed-agentic-operator renamed the Proposal CRD to AgenticRun (OLS-3295). Align CVO by renaming pkg/proposal to pkg/agenticrun and updating all references: types, functions, variables, log strings, env vars, integration tests, and the lightspeed prompt ConfigMap according to OTA-2064. Updates the lightspeed-agentic-operator/api dependency to pick up the renamed types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@jrangelramos: This pull request references OTA-2064 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThe CVO lifecycle integration is migrated from Proposal resources to AgenticRun resources, including reconciliation, controller wiring, analysis schema, prompts, dependency versions, unit tests, and end-to-end payload validation. ChangesAgenticRun migration
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant CVO
participant AgenticRunController
participant KubernetesAPI
CVO->>AgenticRunController: Queue reconciliation
AgenticRunController->>KubernetesAPI: List AgenticRuns
AgenticRunController->>KubernetesAPI: Reconcile owned runs
AgenticRunController->>KubernetesAPI: Create missing AgenticRuns
AgenticRunController->>KubernetesAPI: Delete expired or irrelevant runs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jrangelramos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@jrangelramos: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
The upstream
lightspeed-agentic-operatorrenamed theProposalCRD toAgenticRun(OLS-3295). This PR aligns CVO with that rename (OTA-2064):pkg/proposal/topkg/agenticrun/and updated all types, functions, variables, constants, env vars, log strings, and commentstest/cvo/proposal.gototest/cvo/agenticrun.goand updated integration test referencespkg/cvo/files (cvo.go,status.go,availableupdates.goand their tests) to use the new package and namingpkg/internal/schema.goimport aliaslightspeed-agentic-operator/apidependency to pick up the renamed upstream typesTest plan
go build ./...passesgo test ./pkg/agenticrun/...passesgo test ./pkg/cvo/...passesgo test ./pkg/internal/...passes🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements