Skip to content

OTA-2064: Rename Proposal API to AgenticRun#1422

Open
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:OTA-2064
Open

OTA-2064: Rename Proposal API to AgenticRun#1422
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:OTA-2064

Conversation

@jrangelramos

@jrangelramos jrangelramos commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

The upstream lightspeed-agentic-operator renamed the Proposal CRD to AgenticRun (OLS-3295). This PR aligns CVO with that rename (OTA-2064):

  • Renamed pkg/proposal/ to pkg/agenticrun/ and updated all types, functions, variables, constants, env vars, log strings, and comments
  • Renamed test/cvo/proposal.go to test/cvo/agenticrun.go and updated integration test references
  • Updated pkg/cvo/ files (cvo.go, status.go, availableupdates.go and their tests) to use the new package and naming
  • Updated pkg/internal/schema.go import alias
  • Updated lightspeed prompt ConfigMap and test metadata JSON
  • Bumped lightspeed-agentic-operator/api dependency to pick up the renamed upstream types

Test plan

  • go build ./... passes
  • go test ./pkg/agenticrun/... passes
  • go test ./pkg/cvo/... passes
  • go test ./pkg/internal/... passes
  • CI passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Cluster update advisory workflows now create and manage Agentic Runs.
    • Added structured analysis output covering readiness summaries, findings, and operator status.
    • Agentic Runs are automatically cleaned up when outdated or expired.
  • Improvements

    • Updated advisory prompts and lifecycle checks to reference Agentic Runs.
    • Reconciliation now responds to available update and cluster status changes.
    • Added validation for Agentic Run creation, ownership, expiration, and readiness data.

The upstream lightspeed-agentic-operator renamed the Proposal CRD to
AgenticRun (OLS-3295). Align CVO by renaming pkg/proposal to
pkg/agenticrun and updating all references: types, functions, variables,
log strings, env vars, integration tests, and the lightspeed prompt
ConfigMap according to OTA-2064. Updates the lightspeed-agentic-operator/api
dependency to pick up the renamed types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request references OTA-2064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

The upstream lightspeed-agentic-operator renamed the Proposal CRD to AgenticRun (OLS-3295). This PR aligns CVO with that rename (OTA-2064):

  • Renamed pkg/proposal/ to pkg/agenticrun/ and updated all types, functions, variables, constants, env vars, log strings, and comments
  • Renamed test/cvo/proposal.go to test/cvo/agenticrun.go and updated integration test references
  • Updated pkg/cvo/ files (cvo.go, status.go, availableupdates.go and their tests) to use the new package and naming
  • Updated pkg/internal/schema.go import alias
  • Updated lightspeed prompt ConfigMap and test metadata JSON
  • Bumped lightspeed-agentic-operator/api dependency to pick up the renamed upstream types

Test plan

  • go build ./... passes
  • go test ./pkg/agenticrun/... passes
  • go test ./pkg/cvo/... passes
  • go test ./pkg/internal/... passes
  • CI passes

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

The CVO lifecycle integration is migrated from Proposal resources to AgenticRun resources, including reconciliation, controller wiring, analysis schema, prompts, dependency versions, unit tests, and end-to-end payload validation.

Changes

AgenticRun migration

Layer / File(s) Summary
AgenticRun contracts and configuration
go.mod, pkg/agenticrun/analysis_schema.json, install/...prompts.yaml, pkg/agenticrun/controller.go
Defines the analysis output schema and updates AgenticRun dependency, request wording, namespace configuration, controller identity, labels, naming, and expiration settings.
AgenticRun reconciliation and lifecycle
pkg/agenticrun/controller.go
Creates, expires, garbage-collects, and deletes owned AgenticRun resources while retaining update classification and readiness request generation.
CVO controller wiring and scheduling
pkg/cvo/*.go, pkg/cvo/*_test.go
Replaces the Proposal controller field, initialization, feature gating, queue scheduling, shutdown handling, and status-triggered reconciliation with AgenticRun wiring.
Unit and payload validation
pkg/agenticrun/controller_test.go, pkg/internal/schema.go, test/cvo/agenticrun.go, .openshift-tests-extension/*
Updates tests, Kubernetes scheme registration, CRD checks, resource polling, labels, and scenario naming for AgenticRun resources.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CVO
  participant AgenticRunController
  participant KubernetesAPI
  CVO->>AgenticRunController: Queue reconciliation
  AgenticRunController->>KubernetesAPI: List AgenticRuns
  AgenticRunController->>KubernetesAPI: Reconcile owned runs
  AgenticRunController->>KubernetesAPI: Create missing AgenticRuns
  AgenticRunController->>KubernetesAPI: Delete expired or irrelevant runs
Loading
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign davidhurta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 74315ca link true /test e2e-hypershift-conformance
ci/prow/e2e-agnostic-ovn-techpreview-serial-2of3 74315ca link true /test e2e-agnostic-ovn-techpreview-serial-2of3
ci/prow/verify-update 74315ca link true /test verify-update
ci/prow/e2e-agnostic-ovn 74315ca link true /test e2e-agnostic-ovn
ci/prow/e2e-agnostic-ovn-techpreview-serial-3of3 74315ca link true /test e2e-agnostic-ovn-techpreview-serial-3of3
ci/prow/e2e-aws-ovn-techpreview 74315ca link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-ovn-upgrade-into-change 74315ca link true /test e2e-agnostic-ovn-upgrade-into-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants