WIP: use TLS groups/curve preferences from controller-runtime-common#308
Draft
damdo wants to merge 4 commits into
Draft
WIP: use TLS groups/curve preferences from controller-runtime-common#308damdo wants to merge 4 commits into
damdo wants to merge 4 commits into
Conversation
Bump openshift/api and openshift/client-go to pick up the TLS Groups field in TLSProfileSpec. Add replace directives for controller-runtime-common and library-go forks that implement CurveIDsForTLSGroups. TODO: Remove the replace directives once the TLS groups/curve preferences support is merged and released upstream. Depends on: openshift/controller-runtime-common#22
Update log messages and variable names to reflect that NewTLSConfigFromProfile now returns unsupported groups alongside unsupported ciphers.
Add support for configuring TLS curve preferences via a CLI flag, using numeric Go crypto/tls CurveID values, consistent with the upstream k8s convention (cliflag.TLSCurvePreferences). This won't compile until the k8s 1.36 bump, which introduces cliflag.TLSCurvePreferences in k8s.io/component-base.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller-runtime-commonandlibrary-goforks to pick up TLS groups/curve preferences supportNewTLSConfigFromProfilecurve preferences in the cluster TLS profile path--tls-curve-preferencesCLI flag (numerictls.CurveIDvalues, matchingk8s.io/component-baseconvention)The
--tls-curve-preferencesflag usescliflag.TLSCurvePreferencesfromk8s.io/component-basev0.36+. This won't compile until the k8s 1.36 dependency bump lands.CPO (HyperShift) can leverage
libgocrypto.CurveIDsForTLSGroups()fromo/library-goto convert IANA TLS group names fromo/apiinto numerictls.CurveIDvalues, and pass them to this flag on the CMA Deployment spec.Dependencies
NewTLSConfigFromProfileCurveIDsForTLSGroups/ValidTLSGroupsin library-go cryptocliflag.TLSCurvePreferences)Test plan
--tls-curve-preferences) is expected to fail compilation until the k8s 1.36 bump--tls-curve-preferences 29,23correctly setsCurvePreferenceson the TLS config