Skip to content

NO-JIRA: update owners for CCM-AWS OTE path for SPLAT teeam#468

Draft
mtulio wants to merge 1 commit into
openshift:mainfrom
mtulio:ote-owner-updates
Draft

NO-JIRA: update owners for CCM-AWS OTE path for SPLAT teeam#468
mtulio wants to merge 1 commit into
openshift:mainfrom
mtulio:ote-owner-updates

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented May 29, 2026

Add SPLAT team ownership for the OTE code parts helping support/maintaining across different variants tested on CI.

Summary by CodeRabbit

  • Chores
    • Updated project ownership and code review configuration across multiple test directories to clarify approval workflows and team responsibilities.

Add SPLAT team ownership for the code the team is developing and
maitaining across different variants tested on CI.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@mtulio: This pull request explicitly references no jira issue.

Details

In response to this:

Add SPLAT team ownership for the OTE code parts helping support/maintaining across different variants tested on CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3041261e-4940-4291-9a61-d8936a9e02fc

📥 Commits

Reviewing files that changed from the base of the PR and between 0181640 and 3f3bcf7.

📒 Files selected for processing (3)
  • OWNERS_ALIASES
  • openshift-tests/ccm-aws-tests/OWNERS
  • openshift-tests/operator-tests/OWNERS

Walkthrough

Establishes ownership and review responsibility for cloud controller manager components by defining approver and reviewer alias groups in a central configuration file and then applying those aliases to test directories for AWS and operator testing.

Changes

Ownership and review alias configuration

Layer / File(s) Summary
Alias definitions
OWNERS_ALIASES
Defines three approver/reviewer alias groups: cccmo-approvers/cccmo-reviewers, splat-squad-aws-approvers/splat-squad-aws-reviewers, and splat-squad-vsphere-approvers/splat-squad-vsphere-reviewers, each mapping to specific GitHub usernames.
Test directory ownership configuration
openshift-tests/ccm-aws-tests/OWNERS, openshift-tests/operator-tests/OWNERS
AWS test directory references cccmo and splat-squad-aws alias groups plus adds miyadav as reviewer; operator test directory references cccmo-approvers, cccmo-reviewers, and splat-squad-vsphere-reviewers.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Tests lack complete assertion messages; multiple Expect() calls omit diagnostic text (e.g., Expect(...).NotTo(BeNil()) without failure messages). Add meaningful failure messages to all assertions, e.g., Expect(...).To(..., "descriptive message") throughout loadbalancer.go and credentials_injector_test.go.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to updating owners for CCM-AWS OTE path for SPLAT team, which directly matches the main changes—adding SPLAT team ownership to OWNERS_ALIASES and OWNERS files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All Ginkgo test names use static strings and compile-time constants with no dynamic values that change between test runs.
Microshift Test Compatibility ✅ Passed New Ginkgo tests added use only core Kubernetes APIs available on MicroShift. Both have [OCPFeatureGate:...] tags protecting them from running on incompatible environments.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies OWNERS configuration files, not Ginkgo test code. The check applies only when new tests are added; no new tests are present in this PR.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only OWNERS governance files defining code ownership, not deployment manifests, operator code, or controllers. Topology scheduling check not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies OWNERS configuration files (team metadata), not OTE binary code. The OTE Binary Stdout Contract check targets executable code (main(), init(), suite setup), which is unchanged.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed New AWS loadbalancer tests properly handle IPv6 with IsDualStack detection and don't hardcode IPv4 addresses or require external public internet connectivity.
No-Weak-Crypto ✅ Passed PR contains only OWNERS/ALIASES configuration files (YAML). No weak cryptography, custom crypto, or insecure secret comparisons detected. Check not applicable to configuration-only changes.
Container-Privileges ✅ Passed The PR modifies only Kubernetes OWNERS configuration files that define code ownership and reviewer groups. No container manifests or security configurations are present.
No-Sensitive-Data-In-Logs ✅ Passed PR modifies only OWNERS configuration files containing public GitHub usernames. No sensitive data like passwords, tokens, API keys, PII, or customer data are present in these files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented May 29, 2026

Developing this idea with @JoelSpeed . Joel feeling I am doing something wrong because OWNERS says it's generated automatically, would you mind pointing to the right direction, please?

cc @damdo @jcpowermac @rvanderp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants