Skip to content

NO-JIRA: bump library-go to test preflight pod status reporting#939

Closed
tjungblu wants to merge 1 commit into
openshift:masterfrom
tjungblu:bump-library-go-preflight-pod-status
Closed

NO-JIRA: bump library-go to test preflight pod status reporting#939
tjungblu wants to merge 1 commit into
openshift:masterfrom
tjungblu:bump-library-go-preflight-pod-status

Conversation

@tjungblu

@tjungblu tjungblu commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Replace github.com/openshift/library-go with github.com/tjungblu/library-go at commit 443089d4251c (openshift/library-go#2315) to test preflight pod status condition reporting on a deployed cluster.

Summary by CodeRabbit

  • Chores
    • Reformatted dependency replacement settings into a consolidated, parenthesized format.
    • Redirected one library dependency to a newer mirrored source version.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tjungblu: This pull request explicitly references no jira issue.

Details

In response to this:

Replace github.com/openshift/library-go with github.com/tjungblu/library-go at commit 443089d4251c (openshift/library-go#2315) to test preflight pod status condition reporting on a deployed cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tjungblu tjungblu marked this pull request as draft June 30, 2026 13:01
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2026
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gangwgr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5da692b8-f994-40fc-b9b7-0b1f0246d28d

📥 Commits

Reviewing files that changed from the base of the PR and between 8239d52 and 550a8dc.

⛔ Files ignored due to path filters (16)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/controllers/kms_preflight_controller.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/assets/kms-preflight-pod.yaml is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/checker.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/cmd.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/deployer.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/pod_status.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/pkg/operator/encryption/kms/preflight/pod_template.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/assertion_auth.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/assertion_oas.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/helpers.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/helpers_auth.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/helpers_oas.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/perf_scenarios.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/openshift/library-go/test/library/encryption/scenarios.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

Walkthrough

go.mod reformats the existing ginkgo replace directive into a block and adds a new replacement for github.com/openshift/library-go pointing to github.com/tjungblu/library-go at v0.0.0-20260701080927-76561b5c3767.

Changes

go.mod replace update

Layer / File(s) Summary
Replace block update
go.mod
The ginkgo replace directive is converted to a parenthesized block, and github.com/openshift/library-go is redirected to github.com/tjungblu/library-go v0.0.0-20260701080927-76561b5c3767.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: flavianmissi, rh-roman

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: bumping library-go to test preflight pod status reporting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The commit only changes go.mod dependency replacements; no Ginkgo tests or titles are added or modified.
Test Structure And Quality ✅ Passed PASS: The PR only updates vendored library-go helpers and go.mod; no Ginkgo specs were changed, and the new wait helpers use explicit timeouts.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e specs were added; the diff only updates vendored library-go code and lacks MicroShift-unsafe test blocks.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only go.mod changed to swap library-go deps; no new or modified Ginkgo e2e tests were added, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR only updates go.mod library-go replacement; no manifests/controllers were changed, and existing deployment code already uses node-count/topology-aware rollout logic.
Ote Binary Stdout Contract ✅ Passed PASS: this PR only updates go.mod replace directives; no process-level stdout writes were added, and the OTE main already routes klog to stderr.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo specs were added; the patch only updates vendor/library helpers and a pod template, with no IPv4 literals, host/IP parsing, or external-host access.
No-Weak-Crypto ✅ Passed PR only changes go.mod replace directives; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom/non-constant-time crypto usage appears in the diff.
Container-Privileges ✅ Passed PR only updates go.mod replace directives; no container/K8s manifests were changed, so no new privileged settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes go.mod replace directives; no logging code or sensitive-data strings were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-encryption-kms 56472dd link false /test e2e-aws-operator-encryption-kms

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Replace github.com/openshift/library-go with github.com/tjungblu/library-go
at commit 443089d4251c (openshift/library-go#2315) to test preflight pod
status condition reporting on a deployed cluster.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@tjungblu tjungblu force-pushed the bump-library-go-preflight-pod-status branch from 56472dd to 550a8dc Compare July 1, 2026 08:11
@tjungblu tjungblu closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants