fix(engine): reset thrashing state when user removes reconcile-paused annotation#218
Open
tiraboschi wants to merge 1 commit into
Open
fix(engine): reset thrashing state when user removes reconcile-paused annotation#218tiraboschi wants to merge 1 commit into
tiraboschi wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
❌ Generated Files Verification Failed One or more generated files in this PR are out of sync:
Please regenerate the files locally and commit the changes. |
… annotation When a user removes the platform.kubevirt.io/reconcile-paused annotation to resume reconciliation, the in-memory ThrashingDetector state (consecutiveThrottles >= ThrashingThreshold) was never cleared. If the token bucket was still empty at that point (< 6 s after the pause was set), the very next throttled reconciliation immediately re-paused the resource, making it permanently stuck. Add Step 1.6 in ReconcileAsset: after the IsPaused guard returns false, check whether consecutiveThrottles has already reached the threshold. If so the operator previously set the annotation and the user just removed it, so reset the thrashing detector for that resource. Subsequent throttles now count from 0 and will not re-trigger a pause until a genuine new edit war accumulates enough consecutive throttles. Fixes: CNV-89796 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user removes the platform.kubevirt.io/reconcile-paused annotation to resume reconciliation, the in-memory ThrashingDetector state (consecutiveThrottles >= ThrashingThreshold) was never cleared.
If the token bucket was still empty at that point (< 6 s after the pause was set), the very next throttled reconciliation immediately re-paused the resource, making it permanently stuck.
Add Step 1.6 in ReconcileAsset: after the IsPaused guard returns false, check whether consecutiveThrottles has already reached the threshold. If so the operator previously set the annotation and the user just removed it, so reset the thrashing detector for that resource. Subsequent throttles now count from 0 and will not re-trigger a pause until a genuine new edit war accumulates enough consecutive throttles.
Fixes: CNV-89796