Switch Windows golden image from Win11 to Server 2022#84
Conversation
|
Hi @Ahmad-Hafe. Thanks for your PR. I'm waiting for a openshift-cnv member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
from
f69366a to
85a20e6
Compare
Ahmad-Hafe
changed the title
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
4 times, most recently
from
ed387ad to
b9bbad7
Compare
|
/ok-to-test |
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
2 times, most recently
from
5bbf89a to
8dda9c1
Compare
|
/lgtm on a high level |
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
from
8dda9c1 to
a6874cd
Compare
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
from
14894d8 to
027c837
Compare
orenc1
left a comment
orenc1
left a comment
There was a problem hiding this comment.
looks good, but i have few comments below
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
from
027c837 to
860219c
Compare
… via --tc - Replace Windows 11 golden image setup with Windows Server 2022 - Simplified to single-phase autounattend install (no OOBE phase) - Pass os_login_param credentials via --tc flags instead of hardcoding in test fixtures; can be overridden via WIN_USERNAME/WIN_PASSWORD env vars - Remove redundant firewall rule (firewall is disabled entirely) Signed-off-by: Ahmad Hafe <ahafe@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Ahmad-Hafe
force-pushed
the
feat/win2022-golden-image
branch
from
860219c to
97d34fa
Compare
|
/lgtm |
|
@ksimon1: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ahmad-Hafe, orenc1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Switching to Windows Server 2022 because it's more stable and predictable for testing - no consumer background noise, no forced updates, simpler OOBE.
The tier3 storage tests already target win2k22 and use the same credentials as the QE images, so this aligns the golden image with what we actually run against.
Also simplified from the two-phase pipeline+OOBE approach to a single-phase custom autounattend that handles everything in one go (OS install, OpenSSH, firewall, shutdown).
Tested on test-gcnv15 - boots to desktop, SSH works, guest agent reports, all good.