Revert image flattening and clean node images before disconnected tests#83
Conversation
This reverts commit a43f8b2.
|
/retest ci/prow/images |
|
/retest pull-ci-openshift-cnv-ocp-virt-validation-checkup-main-images |
|
/test images |
1 similar comment
|
/test images |
|
@orenc1 This PR has been successfully tested on openshift/release#79293 (comment) (It has been applied from a gist patch before running the self-validation tool). It's confirmed then that it is working as expected to fully covered the disconnected scenario on the periodic prow job. Please review, thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1, rlobillo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rlobillo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.22 |
|
@rlobillo: new pull request created: #85 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
--keep-manifest-list=trueinstead of--filter-by-os=linux/amd64for internal registry mirrors.crictl rmi --prune) before running disconnected tests to avoid stale cached images from previous runs.More details
The
--filter-by-osflag (when using internal registry) was flattening multi-arch manifests into single-arch images when mirroring to the internal registry. This caused issues because the manifest list are needed for running tier2 testsuite. Reverting to--keep-manifest-list=truepreserves the original manifest structure for all mirror targets.Additionally, a cleanup step is added at the beginning of the disconnected CI script to prune container images cached on each node, preventing leftover images from prior runs from interfering with the test.
What this PR does / why we need it
--filter-by-os=linux/amd64flag for internal registry mirrors and restores--keep-manifest-list=truefor all mirror operations.crictl rmi --pruneon all nodes before mirroring, ensuring a clean state for disconnected validation tests.🤖 Generated with Claude Code