Use EventFactory instead of JacksonEvent.builder() in iceberg-source#6641
Open
lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
Open
Use EventFactory instead of JacksonEvent.builder() in iceberg-source#6641lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
lawofcycles wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Sotaro Hikita <bering1814@gmail.com>
lawofcycles
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces direct usage of
JacksonEvent.builder()withEventFactoryin the iceberg-source plugin, following the standard Data Prepper pattern used by other source plugins such asFileSource. This is a follow-up to #6554.Changes:
EventFactoryas a constructor parameter toIcebergSource,IcebergService,ChangelogWorker, andChangelogRecordConverterJacksonEvent.builder()witheventFactory.eventBuilder(EventBuilder.class)inChangelogRecordConverterIssues Resolved
Related to #6552
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.