Prevent modification of PAID and POSTED bills

[MaramMaruthiChethan]

Description

Fixes an issue where processing a payment attempted to modify bill line items
even when the bill status was PAID or POSTED, resulting in server errors.

Changes

• Block any modification of POSTED bills
• Prevent line item changes for PAID bills
• Fail fast at service layer before persistence

Testing

• mvn test
• All billing-api tests pass locally

[MaramMaruthiChethan]

All related tests are passing locally.
Happy to make any changes if needed.

[MaramMaruthiChethan]

Hi maintainers 👋 Gentle ping on this PR when you get a chance. Happy to address any feedback.

[jayg2002]

Hi maintainers 👋 Gentle ping on this PR when you get a chance. Happy to address any feedback.

Hi @MaramMaruthiChethan , can this PR wait until complete migration of the Bill and BillLineItem are converted to openMRS service.

This Payment processing issue is know before hand , there is a JIRA for it O3-5246 currently handled by Wikum i believe.

I cant be sure of it all, just shared my thoughts.

Fundamental Things missing in the PR:

1. Always create a JIRA for the issue you are resolving with detailed explanation.
2. Tag the maintainers name in the PR comments and also the JIRA link should be mentioned in the PR description.
   3 Write test cases and show evidence of it working if possible.

[MaramMaruthiChethan]

Thanks for the clarification @jayg2002

That makes sense — I wasn’t aware this was already being tracked under O3-5246 or that the billing module is undergoing migration.

I’m happy to pause or close this PR to avoid conflicts, and I’ll follow the proper workflow next time by:

• Creating a JIRA ticket first
• Linking it in the PR
• Coordinating with the relevant maintainers

Thanks for the guidance, really appreciate it.

[MaramMaruthiChethan]

Hi ,I tried creating the JIRA issue but I’m getting a permission error — it says I’m not authorized to create issues. This happened on GitHub/Jira side, not locally.

Could you please help me get access or let me know how to proceed? Thanks!