feat(poolautoscaler): enable feature gate by default - #938
Merged
furykerry merged 1 commit intoSep 4, 2026
Merged
Conversation
Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
- Coverage 83.09% 83.08% -0.01%
==========================================
Files 259 259
Lines 22545 22545
==========================================
- Hits 18733 18732 -1
+ Misses 3091 3090 -1
- Partials 721 723 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
furykerry
added a commit
that referenced
this pull request
Sep 11, 2026
* fix(security): address CodeQL path-injection and log-injection alerts (#928) * fix(security): address CodeQL path-injection and log-injection alerts Add path validation barriers and log sanitization to resolve 43 CodeQL security alerts: - 31 go/path-injection alerts (CWE-22/23/36/73/99) - 12 go/log-injection alerts (CWE-117) Path validation: - Add validateSafePath helper that rejects empty paths and ".." segments - Apply validation before filesystem operations in symlink creation, atomic writer, cert writer, and mount finder - Validate symlink targets and data-directory symlink reads Log sanitization: - Add sanitizeLogValue helper to strip newlines and carriage returns - Apply to all log statements using user-controlled or filesystem paths - Prevents log injection through crafted file names or error messages Affected packages: - cmd/sandbox-gateway-cert-init - pkg/agent-runtime/storage-cli - pkg/agent-runtime/storage-cli/link - pkg/agent-runtime/storage-cli/mountfinder - pkg/utils/webhookutils/writer - pkg/utils/webhookutils/writer/atomic Signed-off-by: 守辰 <shouchen@users.noreply.github.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> * refactor(security): centralize path and log sanitizers Share the duplicated validation and log-value sanitization helpers so the security barriers have one tested implementation to maintain. Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> --------- Signed-off-by: 守辰 <shouchen@users.noreply.github.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> (cherry picked from commit 871ff6e) * docs: add v0.6.0-alpha1 release notes (#932) Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> (cherry picked from commit 27c7201) * fix(sandbox): propagate startup failures to wait-ready and ScalingLimited (#936) (cherry picked from commit fd02f31) * feat(poolautoscaler): enable feature gate by default (#938) Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com> Co-authored-by: 少师 <zengyuwei.zyw@alibaba-inc.com> (cherry picked from commit 0ba722a) * refactor(controller): generalize Pod status synchronization (#939) (cherry picked from commit 1781b7c) * feat(sandbox-manager): load secret config at startup and add startup hook (#857) (cherry picked from commit 0e46dfa) * fix(sandbox): classify unschedulable startup failures (#942) * fix(sandbox): classify unschedulable startup failures Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com> * fix(sandbox): report startup failure reason before pod IP check in claim diagnostics Unschedulable sandboxes have no node assignment and therefore no pod IP, so the pod IP check masked the startup failure reason in wait timeout diagnostics. Check startup failure reasons first so the scheduler message is reported, and add a test covering an empty pod IP with an Unschedulable ready condition. Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com> --------- Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com> Co-authored-by: 少师 <zengyuwei.zyw@alibaba-inc.com> (cherry picked from commit 18d90c1) * fix: unbreak go vet and make build on master (#940) The csi spec bump in #876 (v1.9.0 to v1.13.0) gave csi.NodePublishVolumeRequest a protoimpl.MessageState, which embeds a sync.Mutex. The storage-cli passes that struct by value throughout, so go vet started reporting 18 copylocks findings and exiting 1. Makefile declares vet as a prerequisite of both build and test-e2e, so neither ran. Take the request by pointer instead, which is the normal way to handle a protobuf message and removes a real struct copy from the mount path. make build still produced no binary after that, for a second and unrelated reason: the target compiled a single file rather than the package, so executeCABindings in ca_binding.go was invisible to it. Build the package, matching what the okactl target two lines below already does. go vet ./... is now clean and make build produces bin/agent-sandbox-controller. Fixes #905 Signed-off-by: Om <omlahore47@gmail.com> (cherry picked from commit cb37dce) * feat(sandbox-manager): add network interface binding and reliable peer discovery (#920) (cherry picked from commit 8765d81) * fix(network): format IPv6 upstream addresses (#901) (cherry picked from commit 6971312) * build(deps): bump github/codeql-action/upload-sarif (#949) Bumps [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) from 4.37.8 to 4.37.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@db488dd...cdf488f) --- updated-dependencies: - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 5735cf9) * chore(skill): drop Deployment from sync-charts manifests drift check (#944) * chore(skill): drop Deployment from sync-charts manifests drift check Deployment manifests are no longer synchronized by the manifests drift checker. The comparison now covers only Service, ConfigMap, Ingress, and Secret across the controller, manager, and gateway components. This removes Deployment-only comparison functions, simplifies MANIFEST_SPEC to seven non-Deployment entries, and updates the test suite and SKILL.md accordingly. Signed-off-by: 守辰 <shouchen@example.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> * docs(skill): codify sync policy for manifests drift fixes Document the three-rule sync policy applied when splicing DRIFT findings into chart templates: never modify resource metadata, append only to spec (and to data/stringData on ConfigMap/Secret) without changing existing field values, and never replace a Helm {{ ... }} template expression with a concrete source value. Tests assert the three rules appear in SKILL.md. Signed-off-by: 守辰 <shouchen@example.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> * docs(skill): drop append-only constraint on spec sync policy The spec append-only rule is removed from the manifests sync policy. The remaining rules are: do not modify resource metadata, and never replace a Helm {{ ... }} template expression with a concrete source value on spec, data, or stringData fields. Signed-off-by: 守辰 <shouchen@example.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> * feat(skill): classify templated-field drift and index-based port compare The manifests drift checker now reads the raw chart template file and reclassifies a value-difference DRIFT as TEMPLATED when the affected field is rendered through a {{ ... }} expression or a {{- range }} block, guiding the fix toward updating the values.yaml default instead of hardcoding a literal. Service ports are compared by index so source order matters and chart-only ports are reported by position. The sync policy is restated as three rules: preserve chart-managed metadata while adding source-defined labels/annotations, keep templates and fix values-driven drift via values.yaml defaults, and match source order for indexed lists. Verification now requires a manual diff review for template regressions, because a hardcoded value that matches the source renders identically and cannot be detected by the checker. Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> --------- Signed-off-by: 守辰 <shouchen@example.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> (cherry picked from commit 51149a4) * Tracing user operation (#950) * feat(tracing): emit trace ID as the first JSON log field Install a trace-first JSON zap encoder for the controller so each log line carries the trace ID as its leading field, keeping log collectors that index the first field stable. Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> * feat(tracing): record Sandbox conditions on controller spans Attach each Sandbox condition as a "Status:Reason" span attribute on both the Reconcile span (before) and the updateSandboxStatus span (after), so a single trace shows how a Reconcile iteration drove the condition transition. Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> * feat(tracing): propagate user operations across components Carry the user-facing operation (create/pause/resume/kill) as OTel baggage from the API entry point through to controller Reconcile via a CR annotation, and surface it as the traceOperation log field so cross-component logs can be filtered by operation. Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> * fix(tracing): emit stdout spans as single-line JSON Drop pretty-print from the std-mode stdout exporter so newline-based log collectors treat each span as one entry instead of splitting it into fragments. File mode keeps pretty-print since it is read directly, not line-collected. Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> * fix(tracing): 在 connect 路由入口统一标记 resume Signed-off-by: 马赫 <mahe@bupt.edu.cn> * fix(e2e): 按 JSON 字段校验 tracing 日志 Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> * fix(tracing): address encoder and baggage propagation edge cases Document overridden zap encoder and time flags, handle empty JSON objects, and clear stale baggage before trace injection. Add regression coverage for encoder output and baggage replacement. Co-authored-by: WWKKAA <1938897817@qq.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> --------- Signed-off-by: 马赫 <mahe@bupt.edu.cn> Co-authored-by: WWKKAA <1938897817@qq.com> (cherry picked from commit 3036e82) --------- Signed-off-by: 守辰 <shouchen@users.noreply.github.com> Signed-off-by: 守辰 <shouchen.zz@alibaba-inc.com> Signed-off-by: 少师 <zengyuwei.zyw@alibaba-inc.com> Signed-off-by: Om <omlahore47@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: 守辰 <shouchen@example.com> Signed-off-by: 马赫 <mahe@bupt.edu.cn> Co-authored-by: ywExcellent <yuweizeng97@163.com> Co-authored-by: 少师 <zengyuwei.zyw@alibaba-inc.com> Co-authored-by: Ai Ranthem <zhongtianyun.zty@alibaba-inc.com> Co-authored-by: Om Lahore <omlahore47@gmail.com> Co-authored-by: Shirui Cheng <34178628+cyrilcsr@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: He Ma <71874811+Liquorice-Ma@users.noreply.github.com> Co-authored-by: WWKKAA <1938897817@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Enable PoolAutoscaler by default.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
go build ./pkg/features/...go test ./pkg/controller/poolautoscaler/ -run TestAdd -count=1Ⅳ. Special notes for reviews
None.