fix(runtime): honor refresh and retry before process start - #903
fix(runtime): honor refresh and retry before process start#903RedZapdos123 wants to merge 1 commit into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
==========================================
+ Coverage 82.49% 82.51% +0.01%
==========================================
Files 254 254
Lines 21585 21625 +40
==========================================
+ Hits 17806 17843 +37
- Misses 3080 3082 +2
- Partials 699 700 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description:
Honor runtime refresh and retry before starting process streams.
Before this change,
ProcessAPI.Runresolved transport once from the bound sandbox and calledclient.Startdirectly. As a result, a caller-providedWithRefreshhook could not surface a newly stamped runtime URL or TLS transport, and transient start failures ignored the configuredWithRetrypolicy.This PR keeps the existing process behavior after stream startup, but retries only the pre-first-event startup path against refreshed sandbox snapshots. It also adds regression tests for the missing-runtime-URL refresh path and a transient
CodeUnavailablestart failure.Validation Tests run:
go test ./pkg/utils/runtime -run 'TestRunCommandWithRuntime_RefreshResolvesRuntimeURL|TestRunCommandWithRuntime_RetriesTransientStartError' -count=1 -vgo test ./pkg/utils/runtime -run 'TestRunCommandWithRuntime|TestDoCSIMount|TestChmodFileOnRuntime' -count=1Notes:
ProcessAPI.Run.