fix(controller): use TLS for recycle writes - #888
Conversation
Thread runtime TLS through recycle reset-signal writes so TLS-stamped sandboxes do not fall back to plaintext during CSI reset handling. Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #888 +/- ##
==========================================
- Coverage 82.48% 82.31% -0.17%
==========================================
Files 248 249 +1
Lines 20416 20705 +289
==========================================
+ Hits 16840 17044 +204
- Misses 2927 2991 +64
- Partials 649 670 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@RedZapdos123: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description:
Thread runtime TLS through recycle CSI reset signal writes.
Before this change,
ensureCSIResetSignalcalledWriteFileWithRuntimewithout the transport resolved byruntime.TransportOptionsFor. As a result, a sandbox advertising the runtime TLS capability was silently downgraded to plaintext during recycle.This PR keeps the legacy plaintext behavior for non-TLS sandboxes but binds the controller's existing
RuntimeTLSBundleinto the recycle reset signal write path and adds regression tests for the missing-bundle and configured-bundle paths.Validation Tests run:
go test ./pkg/controller/sandbox/core -run 'TestEnsureCSIResetSignal|TestNewCommonControl_ForwardsRuntimeTLSBundle' -count=1go test ./pkg/controller/sandbox/core -count=1go test ./pkg/controller/sandbox/... -count=1Notes: