Skip to content

[BUG] okactl --wait ignores Ctrl+C. --timeout still works #968

Description

@harkiratsm

What happened:

okactl --wait ignores Ctrl+C. --timeout still works, but SIGINT does not stop the poll.

What you expected to happen:

Ctrl+C should cancel the wait and exit, e.g. waiting for sandboxset "my-pool" update canceled: context canceled.

How to reproduce it (as minimally and precisely as possible):

okactl set image sbs my-pool app=nginx:1.25 --wait --timeout=0
# press Ctrl+C while polling

The process keeps waiting.

Anything else we need to know?:

create, scale, restart, and status have the same issue. Commands use context.TODO() and the CLI does not wire a signal-aware context.

Environment:

  • OpenKruiseAgent version: v0.6.0-alpha1
  • Kubernetes version (use kubectl version): v1.35.1
  • Install details (e.g. helm install args): minikube
  • Others: n/a

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions