Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fabenan-f
force-pushed
the
feat/job-groups-struct
branch
from
eba06d6 to
1eee6e7
Compare
apatsap
left a comment
apatsap
left a comment
There was a problem hiding this comment.
Nice! just one small potential nil-leak
| return nil, nil //nolint:nilnil | ||
| } | ||
| if val, ok := keyVal.(*uuid.UUID); ok { | ||
| return val, nil |
There was a problem hiding this comment.
since val is a pointer we should also check that val != nil
There was a problem hiding this comment.
wouldn't we return in both cases val without error since the group ID can point or be nil?
There was a problem hiding this comment.
You are right! And since its a non-exported function nobody outside will call this. 👍
3 participants
What this PR does / why we need it:
This introduces the job group structure, which represents a collection of jobs that are executed sequentially.