Repository navigation
feat: rewrite ojo_use_template to use new okpolicy-report-template - #23
Conversation
- change from base_dir/project_name to single path parameter - add kebab-case validation for project names - create directory automatically if missing - abort if directory exists and is non-empty - extract cli_yeah() to cli.R for reuse
|
Since this is out first review, just a reminder to push back on any place where I'm overlooking the reasoning behind a change or overriding something in a way you think is a bad idea. This is also going to be way more verbose than in the future because I'm trying to show you my line of thought. Overall this is an extremely good PR from the start. It worked out of the box and explained exactly how to use it. Comments were minimal and all the ones there I found useful and necessary. If there were/are changes to make that take longer to implement that for me to comment on what they are I would kick them back to you but so far everything has been so small that I made the change myself and just want to provide some reasoning in addition to you reviewing the diff of what I changed. I'm also making changes in smallish commits so you can follow easier.
|
- validate template with rlang::arg_match() - map friendly names to github specs internally
|
Added another quality of life thing so we don't have to remember the format for the template. The tradeoff is we can't use arbitrary quarto template paths but I think this is reasonable since our goal is just for our templates |
|
Also didn't know I'd want this but added full interactive mode where it will prompt for the arguments |
|
Failing R-CMD-check is expected and okay. It's an arrow related CI hell trap we aren't going down at this time |
We have updated the Quarto templates for reports and website creation, so we need to update the wrapper function accordingly.