Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Jan 5, 2026

Backout of JDK-8301379 to JDK-11, that made three security tests to fail.

Backporting JDK-8301379 may require a previous backport of the following test refactorings from JDK-17:

  • 8306015: Update sun.security.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
  • 8306014: Update javax.net.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
  • 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

This backout makes all security tests to pass again:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jdk_security                        1361  1361     0     0   
==============================
TEST SUCCESS

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8374213 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3136/head:pull/3136
$ git checkout pull/3136

Update a local copy of the PR:
$ git checkout pull/3136
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3136

View PR using the GUI difftool:
$ git pr show -t 3136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3136.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant