8374711: Hotspot runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails without printing the option name

[MBaesken]

We got the following error today on Linux Alpine :

command: driver TestOptionsWithRanges 9 of 10
reason: User specified action: run driver/timeout=1800 TestOptionsWithRanges 9 of 10

java.lang.Error: Expected only "int", "intx", "size_t", "uint", "uintx", "uint64_t", or "double" option types! Got [Global type!
at optionsvalidation.JVMOption.createVMOption(JVMOption.java:117)
at optionsvalidation.JVMOptionsUtils.getJVMOptions(JVMOptionsUtils.java:282)
at optionsvalidation.JVMOptionsUtils.getOptionsAsMap(JVMOptionsUtils.java:477)
at optionsvalidation.JVMOptionsUtils.getOptionsWithRangeAsMap(JVMOptionsUtils.java:548)
at TestOptionsWithRanges.main(TestOptionsWithRanges.java:213)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
at java.base/java.lang.Thread.run(Thread.java:1516)

It would be helpful to get the option name in the Error output, but this is not yet available. So we should add it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374711: Hotspot runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails without printing the option name (Enhancement - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29089/head:pull/29089
$ git checkout pull/29089

Update a local copy of the PR:
$ git checkout pull/29089
$ git pull https://git.openjdk.org/jdk.git pull/29089/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29089

View PR using the GUI difftool:
$ git pr show -t 29089

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29089.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374711: Hotspot runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails without printing the option name

Reviewed-by: mdoerr, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• dd20e91: 8374521: Support fine-grained native debug levels
• 640343f: 8373724: Assertion failure in TestSignumVector.java with UseAPX
• 3541bc8: 8373538: Migrate all tests to null-safe "SimpleSSLContext" methods
• ... and 1 more: https://git.openjdk.org/jdk/compare/929864b1a40eb222d3b7b3451fc6d4e5316a7cc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6691eafe)

[TheRealMDoerr]

LGTM.

[dholmes-ora]

Trivial enhancement looks good but I don't think it will help with the underlying issue as it seems to be a problem parsing the output of PrintFlagsRanges

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 78b1ca6.
Since your change was applied there have been 16 commits pushed to the master branch:

• c5159fc: 8374328: Convert simple AtomicAccess uses in gc/shared to use Atomic
• 904ba5f: 8374718: Generation of CompilerProperties can fail in subtle ways
• 067fd3c: 8374768: S390X builds are failing after JDK-8372754
• ... and 13 more: https://git.openjdk.org/jdk/compare/929864b1a40eb222d3b7b3451fc6d4e5316a7cc8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 78b1ca6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.